Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview Release ConnectedMachine 2024-03-31 #24909

Merged
merged 56 commits into from
May 29, 2024

Conversation

yaotongms
Copy link
Member

@yaotongms yaotongms commented May 13, 2024

Description

This release is targeting version 2024-03-31-preview of ConnectedMachine.

Changelog:
Add commands that operate on ESU license:

  • Get-AzConnectedLicense: get a list or a specific ESU license
  • New-AzConnectedLicense: create a new ESU license
  • Remove-AzConnectedLicense: remove an ESU license
  • Set-AzConnectedLicense: update an ESU license

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

azure-client-tools-bot-prd bot commented May 13, 2024

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
⚠️Az.ConnectedMachine
️✔️Build
️✔️PowerShell Core - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
⚠️Signature Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzConnectedExtensionMetadata Get-AzConnectedExtensionMetadata Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzConnectedExtensionMetadata Get-AzConnectedExtensionMetadata changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzConnectedLicense Get-AzConnectedLicense Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzConnectedLicense Get-AzConnectedLicense changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzConnectedMachine Get-AzConnectedMachine Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzConnectedMachine Get-AzConnectedMachine changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzConnectedMachineExtension Get-AzConnectedMachineExtension Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzConnectedMachineExtension Get-AzConnectedMachineExtension changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzConnectedMachineRunCommand Get-AzConnectedMachineRunCommand Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzConnectedMachineRunCommand Get-AzConnectedMachineRunCommand changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzConnectedNetworkSecurityPerimeterConfiguration Get-AzConnectedNetworkSecurityPerimeterConfiguration Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzConnectedNetworkSecurityPerimeterConfiguration Get-AzConnectedNetworkSecurityPerimeterConfiguration changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzConnectedPrivateLinkScope Get-AzConnectedPrivateLinkScope Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzConnectedPrivateLinkScope Get-AzConnectedPrivateLinkScope changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzConnectedLicenseDetail New-AzConnectedLicenseDetail Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ New-AzConnectedLicenseDetail New-AzConnectedLicenseDetail changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️Help Example Check
⚠️PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ Get-AzConnectedNetworkSecurityPerimeterConfiguration 1 1 Unassigned_Variable Get-AzConnectedNetworkSecurityPerimeterConfiguration -ResourceGroupName $env.ResourceGroupNameNSP is a null-valued parameter value. -ResourceGroupName Assign value for $env.ResourceGroupNameNSP.
⚠️ Get-AzConnectedNetworkSecurityPerimeterConfiguration 1 1 Unassigned_Variable Get-AzConnectedNetworkSecurityPerimeterConfiguration -ScopeName $env.PrivateLinkScopeNameNSP is a null-valued parameter value. -ScopeName Assign value for $env.PrivateLinkScopeNameNSP.
⚠️ Update-AzConnectedExtension 1 2 Unassigned_Variable Update-AzConnectedExtension -ResourceGroupName $env.ResourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $env.ResourceGroupName.
⚠️ Update-AzConnectedExtension 1 2 Unassigned_Variable Update-AzConnectedExtension -MachineName $machineName is a null-valued parameter value. -MachineName Assign value for $machineName.
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
⚠️File Change Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.ConnectedMachine. Add a changelog record under Upcoming Release section with past tense.
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows

@yaotongms yaotongms changed the title [draft] Preview Release ConnectedMachine 2024-03-31 Preview Release ConnectedMachine 2024-03-31 May 14, 2024
Copy link

‼️ DO NOT MERGE THIS PR ‼️
This PR was labeled "Do Not Merge" because it contains code change that cannot be merged. Please contact the reviewer for more information.

@YanaXu YanaXu merged commit b1f8968 into Azure:generation May 29, 2024
8 checks passed
qinzhouxu pushed a commit to qinzhouxu/azure-powershell that referenced this pull request Jun 5, 2024
* update commands

* update readme

* upload new commands

* remove license commands

* add run commands test

* remove redundant run command

* add run command recordings

* add examples to docs

* fix doc syntax

* add run commands examples

* Upgrade to autorest.powershell v4 for connectemachine

* update to autorest v4

* update run command examples

* update example

* update run command delete

* update old tests

* change comment

* remove get command

* generate commands

* write test

* remove network configuration commands

* remove commands from ESU and all NSP

* add ESU examples

* update docs

* fix syntax issue

* fix syntax

* remove test

* remove test

* remove tests

* separate tests

* add examples

* update test

* add NSP commands

* update tests and docs

* add model cmdlet

* hid guid

* fix docs

* fix docs

* add model cmdlet

* add model cmdlet

* add back NSP

* update tests

* fix test

* update test

* fix docs

* update test

* update test

* update command name

* update command name

* suppress name

* remove test

---------

Co-authored-by: derek <xidi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants