[NVA] Fix update NVA connection cmdlet #24957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️Az.Accounts
️✔️Az.ApplicationInsights
️✔️Az.Batch
️✔️Az.CognitiveServices
️✔️Az.Compute
️✔️Az.ContainerRegistry
️✔️Az.CosmosDB
️✔️Az.DataLakeStore
️✔️Az.Dns
️✔️Az.EventHub
|
| Type | Title | Current Coverage | Description |
|---|---|---|---|
| Test Coverage Less Than 50% | 22.09 % | Test coverage for the module cannot be lower than 50%. |
⚠️ - MacOS
| Type | Title | Current Coverage | Description |
|---|---|---|---|
| Test Coverage Less Than 50% | 22.09% | Test coverage for the module cannot be lower than 50%. |
⚠️ PowerShell Core - Windows
| Type | Title | Current Coverage | Description |
|---|---|---|---|
| Test Coverage Less Than 50% | 22.09% | Test coverage for the module cannot be lower than 50%. |
⚠️ Windows PowerShell - Windows
| Type | Title | Current Coverage | Description |
|---|---|---|---|
| Test Coverage Less Than 50% | 22.09% | Test coverage for the module cannot be lower than 50%. |
️✔️Az.ManagedServiceIdentity
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Az.Monitor
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Test
⚠️ - Linux
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 18.02 % Test coverage for the module cannot be lower than 50%.
⚠️ - MacOS
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 18.02% Test coverage for the module cannot be lower than 50%.
⚠️ PowerShell Core - Windows
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 18.02% Test coverage for the module cannot be lower than 50%.
⚠️ Windows PowerShell - Windows
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 18.02% Test coverage for the module cannot be lower than 50%.
️✔️Az.NetAppFiles
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Network
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Signature Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.OperationalInsights
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.PrivateDns
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Az.RecoveryServices
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Test
⚠️ - Linux
Type Title Current Coverage Last Coverage Description ⚠️ Test Coverage Less Than 80% 62.50 % 66.67% Test coverage cannot be lower than the number of the last release.
⚠️ - MacOS
Type Title Current Coverage Last Coverage Description ⚠️ Test Coverage Less Than 80% 62.50% 66.67% Test coverage cannot be lower than the number of the last release.
⚠️ PowerShell Core - Windows
Type Title Current Coverage Last Coverage Description ⚠️ Test Coverage Less Than 80% 62.50% 66.67% Test coverage cannot be lower than the number of the last release.
⚠️ Windows PowerShell - Windows
Type Title Current Coverage Last Coverage Description ⚠️ Test Coverage Less Than 80% 62.50% 66.67% Test coverage cannot be lower than the number of the last release.
️✔️Az.Resources
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Security
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.ServiceBus
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.SignalR
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Az.Sql
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Test
⚠️ - Linux
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 48.25 % Test coverage for the module cannot be lower than 50%. ️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Storage
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Websites
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
|
@rutuja-s Please update the changelog for this fix. |
|
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
|
updated the change log for the fix |
It is recommended to put the changelog right below the #Upcoming Release title to avoid merge issue.
NoriZC
approved these changes
May 22, 2024
|
/azp run azure-powershell - security-tools |
|
Azure Pipelines successfully started running 1 pipeline(s). |
NoriZC
added a commit
that referenced
this pull request
Jun 27, 2024
* [NVA] Fix update NVA connection cmdlet (#24957) * fix routemap assignment * add change log * Update ChangeLog.md It is recommended to put the changelog right below the #Upcoming Release title to avoid merge issue. --------- Co-authored-by: NoriZC <110961157+NoriZC@users.noreply.github.com> * Adding restart network virtual appliance powershell cmdlets (#25011) * Adding restart nva powershell commandlet * Adding the restart powershell commands * Ading the help document * Updating output * Fixing bug * Adding the tests * Adding code required for confirm * Adding support for date time * Adding test * Adding newly generated files * Adding the test recording * Add platypus generated help file * Editing Az.Network.md * Update src/Network/Network/help/Restart-AzNetworkVirtualAppliance.md Co-authored-by: NoriZC <110961157+NoriZC@users.noreply.github.com> * Adding copyright information to top of file * Adding the help commands * Removing the powershell example prompt --------- Co-authored-by: Arsheen Khatib (from Dev Box) <akhatib@microsoft.com> Co-authored-by: NoriZC <110961157+NoriZC@users.noreply.github.com> * .NET SDK Track 1 changes for NRP 2024-01-01 (#25332) * .NET SDK Track 1 changes for NRP 2024-01-01 * updating changeLog * Updating changelog * Added new properties NetworkIdentifier and ServiceEndpointConfig in Vnet/Subnet config for setting SNAT/VIP. (#25284) * Added new property [-NetworkIdentifier <String>] on Subnet config * updated the type of SENetworkIdentifier from string to PSServiceEndpoint object * Added Fields to support networkidentifier * Added helper file for code refactoring and reusability * Added test Subnet Service Endpoint feature With NetworkIdentifier. * added tests for serviceendpoint with networkidentifier * Distinct to GroupBy fix. * space added --------- Co-authored-by: Bhupesh Bhatt <bhupeshbhatt@microsoft.com> * Updated ChangedLog for Subnet NetworkIdentifier. (#25352) Co-authored-by: Bhupesh Bhatt <bhupeshbhatt@microsoft.com> * [Bastion] Add support for 'Premium' Sku and 'enableSessionRecording' feature flag (#25096) * Init * Updating help * Minor fix * Updating tests * Update help * Update ChangeLog.md * Update ChangeLog.md --------- Co-authored-by: Abhishek Shah <shabhis@microsoft.com> Co-authored-by: NoriZC <110961157+NoriZC@users.noreply.github.com> * NoHealthyBackendsBehavior (#25322) * NoHealthyBackendsBehavior Added the changes necessary for the NoHealthyBackendsBehavior property inside of probe. * Updated changelog * Update LoadBalancerTests.ps1 * Update ChangeLog.md --------- Co-authored-by: NoriZC <110961157+NoriZC@users.noreply.github.com> * Update ChangeLog.md * Update ChangeLog.md Add specific version number to make the Changelog clearer --------- Co-authored-by: rutuja-s <42910715+rutuja-s@users.noreply.github.com> Co-authored-by: NoriZC <110961157+NoriZC@users.noreply.github.com> Co-authored-by: AFK1194 <arsheen.khatib@gmail.com> Co-authored-by: Arsheen Khatib (from Dev Box) <akhatib@microsoft.com> Co-authored-by: Bhupesh Kumar Bhatt <52891188+bhupeshbhatt1985@users.noreply.github.com> Co-authored-by: Bhupesh Bhatt <bhupeshbhatt@microsoft.com> Co-authored-by: Abhishek Shah <16267081+abhi7860@users.noreply.github.com> Co-authored-by: Abhishek Shah <shabhis@microsoft.com> Co-authored-by: Eugenio Peña García <70240915+EugenioPena@users.noreply.github.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minor fix - update NVA connection template
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.