Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Archcoin #1480

Closed
wants to merge 6 commits into from
Closed

Adding Archcoin #1480

wants to merge 6 commits into from

Conversation

BaaSCreator
Copy link

Changelog

  • Adding Archcoin for BaaS integration.

@acomghbot
Copy link

The following issues were detected in this pull request:

Template: archcoin-blockchain-ubuntu

  • The file azuredeploy.json is not valid. Response from ARM API: BadRequest - {"error":{"code":"InvalidTemplateDeployment","message":"The template deployment 'dummy' is not valid according to the validation procedure. The tracking id is 'c749b070-6bd6-40df-8cdb-180a46b3dcce'. See inner errors for details. Please see http://aka.ms/arm-deploy for usage details.","details":[{"code":"InvalidDomainNameLabel","message":"The domain name label GEN-UNIQUE-11 is invalid. It must conform to the following regular expression: ^[a-z][a-z0-9-]{1,61}[a-z0-9]$.","details":[]}]}}

@azurecla
Copy link

Hi @BaaSCreator, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.azure.com.

TTYL, AZPRBOT;

@azurecla
Copy link

@BaaSCreator, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, AZPRBOT;

@acomghbot
Copy link

The following issues were detected in this pull request:

Template: archcoin-blockchain-ubuntu

  • The file azuredeploy.json is not valid. Response from ARM API: BadRequest - {"error":{"code":"InvalidTemplateDeployment","message":"The template deployment 'dummy' is not valid according to the validation procedure. The tracking id is 'f834b127-d863-4b73-b03c-697ec373e291'. See inner errors for details. Please see http://aka.ms/arm-deploy for usage details.","details":[{"code":"InvalidDomainNameLabel","message":"The domain name label GEN-UNIQUE-11 is invalid. It must conform to the following regular expression: ^[a-z][a-z0-9-]{1,61}[a-z0-9]$.","details":[]}]}}

{
"type": "Microsoft.Storage/storageAccounts",
"name": "[variables('storageAccountName')]",
"apiVersion": "[variables('apiVersion')]",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use raw strings for apiVersion, not variables

@gatneil
Copy link
Contributor

gatneil commented Sep 7, 2016

Sorry for the delay; please address the above comments, then we can move forward with this PR :)

@gatneil
Copy link
Contributor

gatneil commented Nov 4, 2016

No response; closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants