Update GetCertificatePolicy-example.json #10783

sebansal · 2020-09-14T19:58:01Z

adding basic constraint description

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

adding basic constraint description

openapi-pipeline-app · 2020-09-14T19:58:04Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

️❌[Staging] PrettierCheck: 2 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` HowToFix	Code style issues found path: preview/7.2-preview/examples/GetCertificatePolicy-example.json
`❌` HowToFix	Code style issues found path: stable/7.1/examples/GetCertificatePolicy-example.json

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

_{Posted by Swagger Pipeline | How to fix these errors?}

azure-pipelines · 2020-09-14T19:58:18Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-09-14T19:59:44Z

Trenton Generation

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-09-14T19:59:44Z

azure-sdk-for-net

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-09-14T19:59:44Z

azure-sdk-for-python

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-09-14T19:59:45Z

azure-sdk-for-go

❌ failed [Logs] [Expand Details]

❌ Generate from 53d0772 with merge commit 9d2c63097a75dfe6787d29557ee502ca1d4879af. SDK Automation 13.0.17.20200909.5

[AutoRest] FATAL: System.InvalidOperationException: output-folder must not be under a preview subdirectory for stable swagger set Microsoft.KeyVault/stable/7.1/certificates.json, Microsoft.KeyVault/stable/7.1/common.json, Microsoft.KeyVault/stable/7.1/keys.json, Microsoft.KeyVault/stable/7.1/secrets.json, Microsoft.KeyVault/stable/7.1/storage.json
[AutoRest]    at AutoRest.Go.CodeGeneratorGo.PreviewCheck(String folder) in /home/vsts/work/1/s/src/CodeGeneratorGo.cs:line 186
[AutoRest]    at AutoRest.Go.CodeGeneratorGo.d__7.MoveNext() in /home/vsts/work/1/s/src/CodeGeneratorGo.cs:line 60
[AutoRest] --- End of stack trace from previous location where exception was thrown ---
[AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
[AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
[AutoRest]    at AutoRest.Go.Program.d__3.MoveNext() in /home/vsts/work/1/s/src/Program.cs:line 107
[AutoRest] --- End of stack trace from previous location where exception was thrown ---
[AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
[AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
[AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
[AutoRest]    at NewPlugin.d__20.MoveNext() in /home/vsts/work/1/s/autorest.common/src/Plugins/NewPlugin.cs:line 163
[AutoRest] FATAL: go/generate - FAILED
[AutoRest] FATAL: Error: Plugin go reported failure.
[AutoRest] Failure during batch task - {"tag":"package-7.1"} -- Error: Plugin go reported failure..
[AutoRest]   Error: Plugin go reported failure.
Failed to run autorest.
Error: /z/node_modules/.bin/autorest --use=@microsoft.azure/autorest.go@~2.1.155 --go --verbose --multiapi --use-onever --preview-chk --version=V2 --go-sdk-folder=/z/work/src/github.com/Azure/azure-sdk-for-go /z/work/azure-rest-api-specs/specification/keyvault/data-plane/readme.md FATAL: System.InvalidOperationException: output-folder must not be under a preview subdirectory for stable swagger set Microsoft.KeyVault/stable/7.1/certificates.json, Microsoft.KeyVault/stable/7.1/common.json, Microsoft.KeyVault/stable/7.1/keys.json, Microsoft.KeyVault/stable/7.1/secrets.json, Microsoft.KeyVault/stable/7.1/storage.json
   at AutoRest.Go.CodeGeneratorGo.PreviewCheck(String folder) in /home/vsts/work/1/s/src/CodeGeneratorGo.cs:line 186
   at AutoRest.Go.CodeGeneratorGo.d__7.MoveNext() in /home/vsts/work/1/s/src/CodeGeneratorGo.cs:line 60
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Go.Program.d__3.MoveNext() in /home/vsts/work/1/s/src/Program.cs:line 107
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at NewPlugin.d__20.MoveNext() in /home/vsts/work/1/s/autorest.common/src/Plugins/NewPlugin.cs:line 163
FATAL: go/generate - FAILED
FATAL: Error: Plugin go reported failure.
Failure during batch task - {"tag":"package-7.1"} -- Error: Plugin go reported failure..
  Error: Plugin go reported failure.
, {} 
Failed to find any diff after autorest so no changed packages was found.

openapi-sdkautomation · 2020-09-14T19:59:45Z

azure-sdk-for-java

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-09-14T19:59:47Z

azure-resource-manager-schemas

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-09-14T19:59:47Z

azure-sdk-for-js

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-09-14T19:59:48Z

Azure CLI Extension Generation

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

...keyvault/data-plane/Microsoft.KeyVault/stable/7.0/examples/GetCertificatePolicy-example.json

…0/examples/GetCertificatePolicy-example.json Co-authored-by: Heath Stewart <heaths@microsoft.com>

azure-pipelines · 2020-09-14T20:47:20Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-09-14T20:51:26Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-09-14T20:52:32Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-09-14T20:53:14Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-09-14T20:58:39Z

azure-sdk-for-python-track2

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

mkreidenweis · 2020-09-26T15:48:21Z

...data-plane/Microsoft.KeyVault/preview/7.2-preview/examples/GetCertificatePolicy-example.json

+          "validity_months": 297,
+          "basic_constraints": {
+            "ca": false,
+            "description": "Optional for leaf certs but needs to be true for CA certificate, if building PKI on top of Key Vault."


The description doesn't look right to me in here -- this is an example response, it wouldn't contain the description.

The description should instead be added to the specification file certificates.json, shouldn't it?

Additionally, the basic_constraints property would need to be added to the swagger. Even if this were valid example JSON, there's no representation in swagger.

ghost · 2020-12-27T16:02:51Z

Hi, @sebansal. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

ghost · 2021-01-17T16:00:43Z

Hi, @sebansal. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

ghost · 2021-02-07T16:01:03Z

Hi, @sebansal. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

ravbhatnagar · 2021-03-19T07:10:15Z

No activity for a long time. please re-add ARM feedback label if you need a review from ARM. removing to reduce noise.

ghost · 2021-04-04T16:00:55Z

Hi, @sebansal. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

openapi-pipeline-app · 2021-04-07T00:40:47Z

Swagger Generation Artifacts

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 7149585490f72608d3c0903976ae7dcddb90ea91. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️keyvault/v7.1/keyvault [View full logs] [Preview SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️keyvault/v7.0/keyvault [View full logs] [Preview SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️keyvault/2016-10-01/keyvault [View full logs] [Preview SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️keyvault/2015-06-01/keyvault [View full logs] [Preview SDK Changes]
```
info	[Changelog] No exported changes
```

️✔️preview/keyvault/v7.2-preview/keyvault [View full logs] [Preview SDK Changes] Breaking Change Detected

Only show 24 items here, please refer to log for details.

info	[Changelog] - New function `RoleDefinitionsClient.GetSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `RoleDefinitionsClient.DeletePreparer(context.Context, string, string, string) (*http.Request, error)`
info	[Changelog] - New function `RoleDefinitionsClient.GetPreparer(context.Context, string, string, string) (*http.Request, error)`
info	[Changelog] - New function `RoleDefinitionsClient.CreateOrUpdateSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `RoleDefinitionsClient.CreateOrUpdateResponder(*http.Response) (RoleDefinition, error)`
info	[Changelog] - New function `RoleDefinitionsClient.CreateOrUpdate(context.Context, string, string, string, RoleDefinitionCreateParameters) (RoleDefinition, error)`
info	[Changelog] - New function `HSMSecurityDomainClient.DownloadPendingPreparer(context.Context, string) (*http.Request, error)`
info	[Changelog] - New function `RoleDefinitionsClient.Get(context.Context, string, string, string) (RoleDefinition, error)`
info	[Changelog] - New function `RoleDefinitionsClient.DeleteResponder(*http.Response) (RoleDefinition, error)`
info	[Changelog] - New function `RoleDefinitionsClient.Delete(context.Context, string, string, string) (RoleDefinition, error)`
info	[Changelog] - New function `RoleDefinitionsClient.DeleteSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `*HSMSecurityDomainDownloadFuture.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `PossibleRoleScopeValues() []RoleScope`
info	[Changelog] - New function `HSMSecurityDomainClient.DownloadPending(context.Context, string) (SecurityDomainOperationStatus, error)`
info	[Changelog] - New struct `HSMSecurityDomainDownloadFuture`
info	[Changelog] - New struct `RoleDefinitionCreateParameters`
info	[Changelog] - New field `Iv` in struct `KeyOperationResult`
info	[Changelog] - New field `AuthenticationTag` in struct `KeyOperationResult`
info	[Changelog] - New field `AdditionalAuthenticatedData` in struct `KeyOperationResult`
info	[Changelog] - New field `Value` in struct `SecurityDomainObject`
info	[Changelog] - New anonymous field `autorest.Response` in struct `RoleDefinition`
info	[Changelog]
info	[Changelog] Total 41 breaking change(s), 62 additive change(s).
info	[Changelog]

_{Posted by Swagger Pipeline | How to fix these errors?}

ghost · 2021-04-25T16:01:03Z

Hi, @sebansal. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

ghost · 2021-05-12T05:00:10Z

Hi, @sebansal. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

JackTn · 2021-08-23T03:42:33Z

Hi, @sebansal. The PR has be closed for a long time and it's related branch still exist. If no further used for over 14 days, I will delete this related branch. Please tell me if you still need this branch.

Update GetCertificatePolicy-example.json

35b20cd

adding basic constraint description

sebansal requested review from heaths, jlichwa and RandalliLama as code owners September 14, 2020 19:58

openapi-assignment-bot bot assigned lmazuel Sep 14, 2020

openapi-assignment-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 14, 2020

sebansal mentioned this pull request Sep 14, 2020

Documentation for X509CertificateProperties is missing basic_constraints #8295

Closed

heaths approved these changes Sep 14, 2020

View reviewed changes

...keyvault/data-plane/Microsoft.KeyVault/stable/7.0/examples/GetCertificatePolicy-example.json Outdated Show resolved Hide resolved

Update specification/keyvault/data-plane/Microsoft.KeyVault/stable/7.…

1b13b2f

…0/examples/GetCertificatePolicy-example.json Co-authored-by: Heath Stewart <heaths@microsoft.com>

Update GetCertificatePolicy-example.json

e65e433

Update GetCertificatePolicy-example.json

1e5ba02

Update GetCertificatePolicy-example.json

53d0772

mkreidenweis reviewed Sep 26, 2020

View reviewed changes

ghost added the no-recent-activity label Dec 27, 2020

heaths removed the no-recent-activity label Dec 29, 2020

ghost added the no-recent-activity label Jan 17, 2021

heaths removed the no-recent-activity label Jan 20, 2021

sebansal mentioned this pull request Jan 29, 2021

[FEATURE REQ] Add basic_constraints to KeyVault Certificates #11962

Open

ghost added the no-recent-activity label Feb 7, 2021

ravbhatnagar removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 19, 2021

ghost removed the no-recent-activity label Mar 19, 2021

ghost added the no-recent-activity label Apr 4, 2021

sebansal closed this Apr 7, 2021

sebansal reopened this Apr 7, 2021

ghost removed the no-recent-activity label Apr 7, 2021

openapi-pipeline-app bot added the CI-BreakingChange-Go label Apr 7, 2021

ghost added the no-recent-activity label Apr 25, 2021

ghost closed this May 12, 2021

sebansal deleted the sebansal-patch-1 branch August 24, 2021 00:39

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update GetCertificatePolicy-example.json #10783

Update GetCertificatePolicy-example.json #10783

sebansal commented Sep 14, 2020 •

edited

Loading

openapi-pipeline-app bot commented Sep 14, 2020 •

edited

Loading

azure-pipelines bot commented Sep 14, 2020

openapi-sdkautomation bot commented Sep 14, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 14, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 14, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 14, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 14, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 14, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 14, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 14, 2020 •

edited

Loading

azure-pipelines bot commented Sep 14, 2020

azure-pipelines bot commented Sep 14, 2020

azure-pipelines bot commented Sep 14, 2020

azure-pipelines bot commented Sep 14, 2020

openapi-sdkautomation bot commented Sep 14, 2020 •

edited

Loading

mkreidenweis Sep 26, 2020

heaths Apr 27, 2021

ghost commented Dec 27, 2020

ghost commented Jan 17, 2021

ghost commented Feb 7, 2021

ravbhatnagar commented Mar 19, 2021

ghost commented Apr 4, 2021

openapi-pipeline-app bot commented Apr 7, 2021 •

edited

Loading

ghost commented Apr 25, 2021

ghost commented May 12, 2021

JackTn commented Aug 23, 2021

Update GetCertificatePolicy-example.json #10783

Update GetCertificatePolicy-example.json #10783

Conversation

sebansal commented Sep 14, 2020 • edited Loading

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-pipeline-app bot commented Sep 14, 2020 • edited Loading

Swagger Validation Report

azure-pipelines bot commented Sep 14, 2020

openapi-sdkautomation bot commented Sep 14, 2020 • edited Loading

Trenton Generation

openapi-sdkautomation bot commented Sep 14, 2020 • edited Loading

azure-sdk-for-net

openapi-sdkautomation bot commented Sep 14, 2020 • edited Loading

azure-sdk-for-python

openapi-sdkautomation bot commented Sep 14, 2020 • edited Loading

azure-sdk-for-go

openapi-sdkautomation bot commented Sep 14, 2020 • edited Loading

azure-sdk-for-java

openapi-sdkautomation bot commented Sep 14, 2020 • edited Loading

azure-resource-manager-schemas

openapi-sdkautomation bot commented Sep 14, 2020 • edited Loading

azure-sdk-for-js

openapi-sdkautomation bot commented Sep 14, 2020 • edited Loading

Azure CLI Extension Generation

azure-pipelines bot commented Sep 14, 2020

azure-pipelines bot commented Sep 14, 2020

azure-pipelines bot commented Sep 14, 2020

azure-pipelines bot commented Sep 14, 2020

openapi-sdkautomation bot commented Sep 14, 2020 • edited Loading

azure-sdk-for-python-track2

mkreidenweis Sep 26, 2020

Choose a reason for hiding this comment

heaths Apr 27, 2021

Choose a reason for hiding this comment

ghost commented Dec 27, 2020

ghost commented Jan 17, 2021

ghost commented Feb 7, 2021

ravbhatnagar commented Mar 19, 2021

ghost commented Apr 4, 2021

openapi-pipeline-app bot commented Apr 7, 2021 • edited Loading

Swagger Generation Artifacts

ghost commented Apr 25, 2021

ghost commented May 12, 2021

JackTn commented Aug 23, 2021

sebansal commented Sep 14, 2020 •

edited

Loading

openapi-pipeline-app bot commented Sep 14, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 14, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 14, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 14, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 14, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 14, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 14, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 14, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 14, 2020 •

edited

Loading

openapi-sdkautomation bot commented Sep 14, 2020 •

edited

Loading

openapi-pipeline-app bot commented Apr 7, 2021 •

edited

Loading