-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue 13147 for HybridDataManager #13296
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added updated swagger file for Microsoft.HybridData
Added swagger and examples for API version 2019-06-01 Adding PartiallySucceeded job status
Ran npm install; npm run prettier -- --write "specification/hybriddatamanager/**/*.json"
Fix issue Azure#13147 in hybriddatamanager
Hi, @prtank Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
Swagger Generation Artifacts
|
This was referenced Mar 5, 2021
timotheeguerin
approved these changes
Mar 5, 2021
PhoenixHe-NV
approved these changes
Mar 8, 2021
This was referenced Mar 8, 2021
ghost
pushed a commit
to Azure/azure-resource-manager-schemas
that referenced
this pull request
Mar 8, 2021
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
* Create hybriddata.json Added updated swagger file for Microsoft.HybridData * Create readme.md * Updated readme files * Update readme.md * Removed unused API endpoints * Updated example files and swagger * Fixed error in path to example files * Fixed Go and Ruby Readme Files * Added suppression for OperationIdNounVerb * Added DataManagers_Update and examples * Added suppression for ARM Violation and updated swagger and example files * Updated swagger to sdk script for ruby * Added Python swagger to sdk * Added PartiallySucceeded status * Added swagger and examples for API Version 2019-06-01 Added swagger and examples for API version 2019-06-01 Adding PartiallySucceeded job status * Removed partially succeeded status from 2016-06-01 swagger * Updating body of 202 response * After running prettier Ran npm install; npm run prettier -- --write "specification/hybriddatamanager/**/*.json" * Updated readme files to include 2019-06 api version * Updated descriptions as per PR comments * Committing Prettier check change * Updated HybridDataManager to fix issue 13147 Fix issue Azure#13147 in hybriddatamanager Co-authored-by: t-prta <46665688+prerna-tank-ms@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
[ x] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.