Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Delete Machines API #26420

Merged
merged 6 commits into from
Oct 30, 2023
+96 −0

fix

83eab12
Select commit
Loading
Failed to load commit list.
Merged

Add Delete Machines API #26420

fix
83eab12
Select commit
Loading
Failed to load commit list.
openapi-pipeline-app / ~[NotRequired_Staging] Swagger LintDiff failed Oct 27, 2023 in 2m 56s

~[NotRequired_Staging] Swagger LintDiff failed

ppe/LintDiff: 2 Errors, 14 Warnings
View more details.

Details

compared tags (via openapi-validator vbeta) new version base version
package-preview-2023-10 package-preview-2023-10(83eab12) package-preview-2023-10(FumingZhang-containerservice-Microsoft.ContainerService-2023-10-02-preview)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
❌ FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-10-02-preview/managedClusters.json'. Errors encountered: Error: Error running Nimma Error 1: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 2: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 3: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 4: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 5: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 6: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 7: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 8: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 9: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 10: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 11: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 12: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 13: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 14: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 15: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 16: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 17: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 18: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 19: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 20: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 21: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 22: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 23: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 24: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 25: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 26: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 27: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 28: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 29: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 30: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 31: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 32: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 33: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 34: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 35: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 36: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 37: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 38: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 39: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 40: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 41: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 42: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 43: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 44: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 45: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 46: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 47: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined') Error 48: $[paths,'x-ms-paths'].* threw: ErrorWithCause('Function 'patchPropertiesCorrespondToPutProperties' threw an exception: Cannot read property 'length' of undefined')
Location: azure-rest-api-specs/blob/83eab128e2752d1f16bc4394dc1a886d58e9c919/#L1


The following errors/warnings exist before current PR submission:

Rule Message
❌ PrivateEndpointResourceSchemaValidation The private endpoint model 'PrivateLinkResourcesListResult' schema does not conform to the common type definition.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L2226
⚠️ PostOperationIdContainsUrlVerb OperationId should contain the verb: 'resolveprivatelinkserviceid' in:'ResolvePrivateLinkServiceId_POST'. Consider updating the operationId
Location: aks/preview/2023-10-02-preview/managedClusters.json#L2251
⚠️ PageableOperation Based on the response model schema, operation 'PrivateLinkResources_List' might be pageable. Consider adding the x-ms-pageable extension.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L2204
⚠️ RequiredReadOnlySystemData The response of operation:'PrivateEndpointConnections_Update' is defined without 'systemData'. Consider adding the systemData to the response.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L2033
⚠️ RequiredReadOnlySystemData The response of operation:'PrivateEndpointConnections_Get' is defined without 'systemData'. Consider adding the systemData to the response.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L1985
⚠️ PageableOperation Based on the response model schema, operation 'PrivateEndpointConnections_List' might be pageable. Consider adding the x-ms-pageable extension.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L1942
⚠️ RequiredReadOnlySystemData The response of operation:'Machines_Get' is defined without 'systemData'. Consider adding the systemData to the response.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L1458
⚠️ RequiredReadOnlySystemData The response of operation:'AgentPools_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L1127
⚠️ RequiredReadOnlySystemData The response of operation:'AgentPools_Get' is defined without 'systemData'. Consider adding the systemData to the response.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L1084
⚠️ UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get Managed Cluster
Location: aks/preview/2023-10-02-preview/managedClusters.json#L502
⚠️ UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get Managed Cluster
Location: aks/preview/2023-10-02-preview/managedClusters.json#L460
⚠️ UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get Managed Cluster
Location: aks/preview/2023-10-02-preview/managedClusters.json#L415
⚠️ UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get Managed Cluster
Location: aks/preview/2023-10-02-preview/managedClusters.json#L367
⚠️ PostOperationIdContainsUrlVerb OperationId should contain the verb: 'listcredential' in:'ManagedClusters_GetAccessProfile'. Consider updating the operationId
Location: aks/preview/2023-10-02-preview/managedClusters.json#L284
⚠️ PageableOperation Based on the response model schema, operation 'ManagedClusters_ListKubernetesVersions' might be pageable. Consider adding the x-ms-pageable extension.
Location: aks/preview/2023-10-02-preview/managedClusters.json#L116
View more details on openapi-pipeline-app