Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Microsoft.Resources] New api-version #28788

Merged
merged 40 commits into from
Aug 10, 2024
Merged

[Microsoft.Resources] New api-version #28788

merged 40 commits into from
Aug 10, 2024

Conversation

jorgecotillo
Copy link
Contributor

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

Note

As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

Click here to see the details of Step 1, Breaking Changes review

If you are in purview of Step 1 of the diagram, follow the Breaking Changes review process.
IMPORTANT! This applies even if you believe your PR was mislabeled, for any reason, including tool failure.

Click here to see the details of Step 2, ARM review

See https://aka.ms/azsdk/pr-arm-review.

Click here to see the diagram footnotes

Diagram footnotes

[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Copy link

openapi-pipeline-app bot commented Apr 22, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented Apr 22, 2024

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️❌Breaking Change(Cross-Version): 2 Errors, 17 Warnings failed [Detail]
Compared specs (v0.10.12) new version base version
resources.json 2024-07-01(6a88c34) 2024-03-01(main)

The following breaking changes are detected by comparison with the latest stable version:

Rule Message
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'error' renamed or removed?
New: Microsoft.Resources/stable/2024-07-01/resources.json#L5533:7
Old: Microsoft.Resources/stable/2024-03-01/resources.json#L5444:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'properties' renamed or removed?
New: Microsoft.Resources/stable/2024-07-01/resources.json#L5525:7
Old: Microsoft.Resources/stable/2024-03-01/resources.json#L5444:7
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.Resources/stable/2024-07-01/resources.json#L285:13
Old: Microsoft.Resources/stable/2024-03-01/resources.json#L285:13
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.Resources/stable/2024-07-01/resources.json#L294:13
Old: Microsoft.Resources/stable/2024-03-01/resources.json#L294:13
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.Resources/stable/2024-07-01/resources.json#L5526:9
Old: Microsoft.Resources/stable/2024-03-01/resources.json#L5445:9
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: common-types/resource-management/v6/types.json#L241:11
Old: common-types/resource-management/v1/types.json#L308:11
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.Resources/stable/2024-07-01/resources.json#L595:13
Old: Microsoft.Resources/stable/2024-03-01/resources.json#L590:13
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.Resources/stable/2024-07-01/resources.json#L604:13
Old: Microsoft.Resources/stable/2024-03-01/resources.json#L599:13
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.Resources/stable/2024-07-01/resources.json#L979:13
Old: Microsoft.Resources/stable/2024-03-01/resources.json#L969:13
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.Resources/stable/2024-07-01/resources.json#L988:13
Old: Microsoft.Resources/stable/2024-03-01/resources.json#L978:13
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.Resources/stable/2024-07-01/resources.json#L1372:13
Old: Microsoft.Resources/stable/2024-03-01/resources.json#L1357:13
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.Resources/stable/2024-07-01/resources.json#L1381:13
Old: Microsoft.Resources/stable/2024-03-01/resources.json#L1366:13
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.Resources/stable/2024-07-01/resources.json#L1834:13
Old: Microsoft.Resources/stable/2024-03-01/resources.json#L1814:13
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.Resources/stable/2024-07-01/resources.json#L1843:13
Old: Microsoft.Resources/stable/2024-03-01/resources.json#L1823:13
⚠️ 1040 - AddedReadOnlyPropertyInResponse The new version has a new read-only property 'diagnostics' in response that was not found in the old version.
New: Microsoft.Resources/stable/2024-07-01/resources.json#L5329:7
Old: Microsoft.Resources/stable/2024-03-01/resources.json#L5256:7
⚠️ 1040 - AddedReadOnlyPropertyInResponse The new version has a new read-only property 'id' in response that was not found in the old version.
New: Microsoft.Resources/stable/2024-07-01/resources.json#L5533:7
Old: Microsoft.Resources/stable/2024-03-01/resources.json#L5444:7
⚠️ 1040 - AddedReadOnlyPropertyInResponse The new version has a new read-only property 'name' in response that was not found in the old version.
New: Microsoft.Resources/stable/2024-07-01/resources.json#L5533:7
Old: Microsoft.Resources/stable/2024-03-01/resources.json#L5444:7
⚠️ 1040 - AddedReadOnlyPropertyInResponse The new version has a new read-only property 'type' in response that was not found in the old version.
New: Microsoft.Resources/stable/2024-07-01/resources.json#L5533:7
Old: Microsoft.Resources/stable/2024-03-01/resources.json#L5444:7
⚠️ 1040 - AddedReadOnlyPropertyInResponse The new version has a new read-only property 'diagnostics' in response that was not found in the old version.
New: Microsoft.Resources/stable/2024-07-01/resources.json#L6523:7
Old: Microsoft.Resources/stable/2024-03-01/resources.json#L6448:7
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
Compared specs (v2.2.2) new version base version
default default(6a88c34) default(main)
️❌Avocado: 38 Errors, 0 Warnings failed [Detail]

Only 30 items are listed, please refer to log for more details.

Rule Message
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/resources/resource-manager/readme.md
json: stable/2024-07-01/examples/CalculateTemplateHash.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/resources/resource-manager/readme.md
json: stable/2024-07-01/examples/CreateResourceGroup.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/resources/resource-manager/readme.md
json: stable/2024-07-01/examples/DeleteTagsResource.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/resources/resource-manager/readme.md
json: stable/2024-07-01/examples/DeleteTagsSubscription.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/resources/resource-manager/readme.md
json: stable/2024-07-01/examples/ExportResourceGroup.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/resources/resource-manager/readme.md
json: stable/2024-07-01/examples/ExportResourceGroupAsBicep.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/resources/resource-manager/readme.md
json: stable/2024-07-01/examples/ExportResourceGroupWithFiltering.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/resources/resource-manager/readme.md
json: stable/2024-07-01/examples/ForceDeleteVMsAndVMSSInResourceGroup.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/resources/resource-manager/readme.md
json: stable/2024-07-01/examples/ForceDeleteVMsInResourceGroup.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/resources/resource-manager/readme.md
json: stable/2024-07-01/examples/GetNamedProviderAtTenant.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/resources/resource-manager/readme.md
json: stable/2024-07-01/examples/GetProvider.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/resources/resource-manager/readme.md
json: stable/2024-07-01/examples/GetProviderPermissions.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/resources/resource-manager/readme.md
json: stable/2024-07-01/examples/GetProviderResourceTypes.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/resources/resource-manager/readme.md
json: stable/2024-07-01/examples/GetProviders.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/resources/resource-manager/readme.md
json: stable/2024-07-01/examples/GetTagsResource.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/resources/resource-manager/readme.md
json: stable/2024-07-01/examples/GetTagsSubscription.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/resources/resource-manager/readme.md
json: stable/2024-07-01/examples/PatchTagsResource.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/resources/resource-manager/readme.md
json: stable/2024-07-01/examples/PatchTagsSubscription.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/resources/resource-manager/readme.md
json: stable/2024-07-01/examples/PostDeploymentValidateOnManagementGroup.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/resources/resource-manager/readme.md
json: stable/2024-07-01/examples/PostDeploymentValidateOnResourceGroup.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/resources/resource-manager/readme.md
json: stable/2024-07-01/examples/PostDeploymentValidateOnScope.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/resources/resource-manager/readme.md
json: stable/2024-07-01/examples/PostDeploymentValidateOnSubscription.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/resources/resource-manager/readme.md
json: stable/2024-07-01/examples/PostDeploymentValidateOnTenant.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/resources/resource-manager/readme.md
json: stable/2024-07-01/examples/PostDeploymentWhatIfOnManagementGroup.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/resources/resource-manager/readme.md
json: stable/2024-07-01/examples/PostDeploymentWhatIfOnResourceGroup.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/resources/resource-manager/readme.md
json: stable/2024-07-01/examples/PostDeploymentWhatIfOnSubscription.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/resources/resource-manager/readme.md
json: stable/2024-07-01/examples/PostDeploymentWhatIfOnTenant.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/resources/resource-manager/readme.md
json: stable/2024-07-01/examples/PutDeploymentAtManagementGroup.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/resources/resource-manager/readme.md
json: stable/2024-07-01/examples/PutDeploymentAtScope.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/resources/resource-manager/readme.md
json: stable/2024-07-01/examples/PutDeploymentAtTenant.json
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Apr 22, 2024

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️⚠️ azure-sdk-for-net-track2 warning [Detail]
    For more instructions, please refer to the FAQ .
  • ⚠️Warning in generating from db0ded437ba3d09f1ee35e98ba07026fbf36e1cd. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Get-ChildItem: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:787
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
    cmderr	[Invoke-GenerateAndBuildV2.ps1]  787 |  … rtifacts += Get-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s …
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Cannot find path
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | it does not exist.
    warn	Warning: No file changes detected after the generation. Please refer to the generation errors to understand the reasons.
  • ️✔️Azure.ResourceManager.Resources
    info	[Changelog]
️⚠️ azure-sdk-for-python warning [Detail]
    For more instructions, please refer to the FAQ .
  • ⚠️Warning in generating from db0ded437ba3d09f1ee35e98ba07026fbf36e1cd. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    cmderr	[automation_init.sh] npm notice
    cmderr	[automation_init.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.1
    cmderr	[automation_init.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.1
    cmderr	[automation_init.sh] npm notice To update run: npm install -g npm@10.8.1
    cmderr	[automation_init.sh] npm notice
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
  • ️✔️azure-mgmt-resource [Preview SDK Changes]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog]   - Added operation group PolicyDefinitionVersionsOperations
    info	[Changelog]   - Added operation group PolicySetDefinitionVersionsOperations
    info	[Changelog]   - Model ParameterDefinitionsValue has a new parameter schema
    info	[Changelog]   - Model PolicyAssignment has a new parameter definition_version
    info	[Changelog]   - Model PolicyDefinition has a new parameter version
    info	[Changelog]   - Model PolicyDefinition has a new parameter versions
    info	[Changelog]   - Model PolicyDefinitionReference has a new parameter definition_version
    info	[Changelog]   - Model PolicySetDefinition has a new parameter version
    info	[Changelog]   - Model PolicySetDefinition has a new parameter versions
️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    For more instructions, please refer to the FAQ .
  • ️✔️Succeeded in generating from db0ded437ba3d09f1ee35e98ba07026fbf36e1cd. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-resources-generated [Preview SDK Changes]
    info	[Changelog]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    For more instructions, please refer to the FAQ .
  • ️✔️Succeeded in generating from db0ded437ba3d09f1ee35e98ba07026fbf36e1cd. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/resources/armresources [Preview SDK Changes] Breaking Change Detected
    Only showing 11 items here. Refer to log for details.
    info	[Changelog]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog] - New enum type `ExportTemplateOutputFormat` with values `ExportTemplateOutputFormatBicep`, `ExportTemplateOutputFormatJSON`
    info	[Changelog] - New struct `DeploymentParameter`
    info	[Changelog] - New struct `KeyVaultParameterReference`
    info	[Changelog] - New struct `KeyVaultReference`
    info	[Changelog] - New field `OutputFormat` in struct `ExportTemplateRequest`
    info	[Changelog] - New field `Output` in struct `ResourceGroupExportResult`
    info	[Changelog]
    info	[Changelog] Total 5 breaking change(s), 11 additive change(s).
    Present SDK breaking changes suppressions
    Operation `*TagsClient.CreateOrUpdateAtScope` has been changed to LRO, use `*TagsClient.BeginCreateOrUpdateAtScope` instead.
    Operation `*TagsClient.DeleteAtScope` has been changed to LRO, use `*TagsClient.BeginDeleteAtScope` instead.
    Operation `*TagsClient.UpdateAtScope` has been changed to LRO, use `*TagsClient.BeginUpdateAtScope` instead.
    Type of `DeploymentProperties.Parameters` has been changed from `any` to `map[string]*DeploymentParameter`
    Type of `DeploymentWhatIfProperties.Parameters` has been changed from `any` to `map[string]*DeploymentParameter`
    Please refer to the guidance for suppressing SDK breaking changes.
  • ️✔️sdk/resourcemanager/resources/armdeploymentscripts [Preview SDK Changes]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog] - New struct `ContainerGroupSubnetID`
    info	[Changelog] - New field `SubnetIDs` in struct `ContainerConfiguration`
    info	[Changelog]
    info	[Changelog] Total 0 breaking change(s), 3 additive change(s).
  • ️✔️sdk/resourcemanager/resources/armfeatures [Preview SDK Changes]
    info	[Changelog] ### Other Changes
    info	[Changelog]
    info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
  • ️✔️sdk/resourcemanager/resources/armlinks [Preview SDK Changes]
    info	[Changelog] ### Other Changes
    info	[Changelog]
    info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
  • ️✔️sdk/resourcemanager/resources/armlocks [Preview SDK Changes]
    info	[Changelog] ### Other Changes
    info	[Changelog]
    info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
  • ️✔️sdk/resourcemanager/resources/armmanagedapplications [Preview SDK Changes]
    info	[Changelog] ### Other Changes
    info	[Changelog]
    info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
  • ️✔️sdk/resourcemanager/resources/armpolicy [Preview SDK Changes]
  • ️✔️sdk/resourcemanager/resources/armsubscriptions [Preview SDK Changes]
    info	[Changelog] ### Other Changes
    info	[Changelog]
    info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
  • ️✔️sdk/resourcemanager/resources/armtemplatespecs [Preview SDK Changes]
    info	[Changelog] ### Other Changes
    info	[Changelog]
    info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
  • ️✔️sdk/resourcemanager/resources/armchanges [Preview SDK Changes]
    info	[Changelog] ### Other Changes
    info	[Changelog]
    info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
  • ️✔️sdk/resourcemanager/resources/armdeploymentstacks [Preview SDK Changes]
    info	[Changelog] ### Other Changes
    info	[Changelog]
    info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    For more instructions, please refer to the FAQ .
  • ️✔️Succeeded in generating from db0ded437ba3d09f1ee35e98ba07026fbf36e1cd. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	Warning: File azure-sdk-for-js_tmp/initOutput.json not found to read. Please re-run the pipeline if the error is transitient error or report this issue through https://aka.ms/azsdk/support/specreview-channel.
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    cmderr	[automation_generate.sh] [ERROR] Cannot generate changelog because the codes of local and npm may be the same.
    cmderr	[automation_generate.sh] [ERROR] Cannot generate changelog because the codes of local and npm may be the same.
  • ️✔️@azure/arm-changes [Preview SDK Changes] Breaking Change Detected
    info	[Changelog] **Breaking Changes**
    info	[Changelog]
    info	[Changelog]   - Interface ChangesListNextOptionalParams no longer has parameter skipToken
    info	[Changelog]   - Interface ChangesListNextOptionalParams no longer has parameter top
    Present SDK breaking changes suppressions
    This package has no defined suppressions.
    Absent SDK breaking changes suppressions
    - Interface ChangesListNextOptionalParams no longer has parameter skipToken
    - Interface ChangesListNextOptionalParams no longer has parameter top
    Please refer to the guidance for suppressing SDK breaking changes.
  • ️✔️@azure/arm-features [Preview SDK Changes] Breaking Change Detected
    info	[Changelog] **Breaking Changes**
    info	[Changelog]
    info	[Changelog]   - Class FeatureClient has a new signature
    Present SDK breaking changes suppressions
    This package has no defined suppressions.
    Absent SDK breaking changes suppressions
    - Class FeatureClient has a new signature
    Please refer to the guidance for suppressing SDK breaking changes.
  • ️✔️@azure/arm-links [Preview SDK Changes] Breaking Change Detected
    info	[Changelog] **Breaking Changes**
    info	[Changelog]
    info	[Changelog]   - Class ManagementLinkClient has a new signature
    info	[Changelog]   - Interface ResourceLinksListAtSubscriptionNextOptionalParams no longer has parameter filter
    Present SDK breaking changes suppressions
    This package has no defined suppressions.
    Absent SDK breaking changes suppressions
    - Class ManagementLinkClient has a new signature
    - Interface ResourceLinksListAtSubscriptionNextOptionalParams no longer has parameter filter
    Please refer to the guidance for suppressing SDK breaking changes.
  • ️✔️@azure/arm-locks [Preview SDK Changes] Breaking Change Detected
    info	[Changelog] **Breaking Changes**
    info	[Changelog]
    info	[Changelog]   - Class ManagementLockClient has a new signature
    info	[Changelog]   - Interface ManagementLocksListAtResourceGroupLevelNextOptionalParams no longer has parameter filter
    info	[Changelog]   - Interface ManagementLocksListAtResourceLevelNextOptionalParams no longer has parameter filter
    info	[Changelog]   - Interface ManagementLocksListAtSubscriptionLevelNextOptionalParams no longer has parameter filter
    info	[Changelog]   - Interface ManagementLocksListByScopeNextOptionalParams no longer has parameter filter
    Present SDK breaking changes suppressions
    This package has no defined suppressions.
    Absent SDK breaking changes suppressions
    - Class ManagementLockClient has a new signature
    - Interface ManagementLocksListAtResourceGroupLevelNextOptionalParams no longer has parameter filter
    - Interface ManagementLocksListAtResourceLevelNextOptionalParams no longer has parameter filter
    - Interface ManagementLocksListAtSubscriptionLevelNextOptionalParams no longer has parameter filter
    - Interface ManagementLocksListByScopeNextOptionalParams no longer has parameter filter
    Please refer to the guidance for suppressing SDK breaking changes.
  • ️✔️@azure/arm-managedapplications [Preview SDK Changes] Breaking Change Detected
    Only showing 12 items here. Refer to log for details.
    info	[Changelog]   - Removed Enum KnownApplicationDefinitionArtifactName
    info	[Changelog]   - Removed Enum KnownApplicationManagementMode
    info	[Changelog]   - Removed Enum KnownCreatedByType
    info	[Changelog]   - Removed Enum KnownDeploymentMode
    info	[Changelog]   - Removed Enum KnownJitApprovalMode
    info	[Changelog]   - Removed Enum KnownJitApproverType
    info	[Changelog]   - Removed Enum KnownJitRequestState
    info	[Changelog]   - Removed Enum KnownJitSchedulingType
    info	[Changelog]   - Removed Enum KnownOrigin
    info	[Changelog]   - Removed Enum KnownStatus
    info	[Changelog]   - Removed Enum KnownSubstatus
    info	[Changelog]   - Enum KnownProvisioningState no longer has value NotSpecified
    Present SDK breaking changes suppressions
    This package has no defined suppressions.
    Only showing 12 items here. Refer to log for details.
    Absent SDK breaking changes suppressions
    - Removed operation Applications.beginUpdateAndWait
    - Removed operation Applications.beginUpdateById
    - Removed operation Applications.beginUpdateByIdAndWait
    - Removed operation Applications.listAllowedUpgradePlans
    - Removed operation Applications.listTokens
    - Removed operation group JitRequests
    - Type of parameter artifacts of interface ApplicationDefinition is changed from ApplicationDefinitionArtifact[] to ApplicationArtifact[]
    - Type of parameter authorizations of interface ApplicationDefinition is changed from ApplicationAuthorization[] to ApplicationProviderAuthorization[]
    - Type of parameter isEnabled of interface ApplicationDefinition is changed from boolean to string
    - Type of parameter name of interface ApplicationArtifact is changed from ApplicationArtifactName to string
    - Type of parameter parameters of interface ApplicationsUpdateByIdOptionalParams is changed from ApplicationPatchable to Application
    - Type of parameter type of interface Identity is changed from ResourceIdentityType to "SystemAssigned"
    Please refer to the guidance for suppressing SDK breaking changes.
  • ️✔️@azure/arm-policy [Preview SDK Changes]
  • ️✔️@azure/arm-resources-subscriptions [Preview SDK Changes]
    info	[Changelog]
    error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
  • ️✔️@azure/arm-resources [Preview SDK Changes] Breaking Change Detected
    Only showing 12 items here. Refer to log for details.
    info	[Changelog]   - Interface TagsUpdateAtScopeOptionalParams has a new optional parameter updateIntervalInMs
    info	[Changelog]   - Added Enum KnownExportTemplateOutputFormat
    info	[Changelog]
    info	[Changelog] **Breaking Changes**
    info	[Changelog]
    info	[Changelog]   - Removed operation TagsOperations.createOrUpdateAtScope
    info	[Changelog]   - Removed operation TagsOperations.deleteAtScope
    info	[Changelog]   - Removed operation TagsOperations.updateAtScope
    info	[Changelog]   - Class ResourceManagementClient has a new signature
    info	[Changelog]   - Type of parameter parameters of interface DeploymentProperties is changed from Record<string, unknown> to {
    info	[Changelog]         [propertyName: string]: DeploymentParameter;
    info	[Changelog]     }
    Present SDK breaking changes suppressions
    This package has no defined suppressions.
    Absent SDK breaking changes suppressions
    - Class ResourceManagementClient has a new signature
    - Removed operation TagsOperations.createOrUpdateAtScope
    - Removed operation TagsOperations.deleteAtScope
    - Removed operation TagsOperations.updateAtScope
    - "Type of parameter parameters of interface DeploymentProperties is changed from Record<string, unknown> to {\n        [propertyName: string]: DeploymentParameter;\n    }"
    Please refer to the guidance for suppressing SDK breaking changes.
  • ️✔️@azure/arm-resourcesdeploymentstacks [Preview SDK Changes]
    info	[Changelog]
    error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
  • ️✔️@azure/arm-templatespecs [Preview SDK Changes] Breaking Change Detected
    Only showing 12 items here. Refer to log for details.
    info	[Changelog]   - Added Type Alias TemplateSpecsGetBuiltInResponse
    info	[Changelog]   - Added Type Alias TemplateSpecsListBuiltInsNextResponse
    info	[Changelog]   - Added Type Alias TemplateSpecsListBuiltInsResponse
    info	[Changelog]   - Added Type Alias TemplateSpecVersionsGetBuiltInResponse
    info	[Changelog]   - Added Type Alias TemplateSpecVersionsListBuiltInsNextResponse
    info	[Changelog]   - Added Type Alias TemplateSpecVersionsListBuiltInsResponse
    info	[Changelog]
    info	[Changelog] **Breaking Changes**
    info	[Changelog]
    info	[Changelog]   - Class TemplateSpecsClient has a new signature
    info	[Changelog]   - Interface TemplateSpecsListByResourceGroupNextOptionalParams no longer has parameter expand
    info	[Changelog]   - Interface TemplateSpecsListBySubscriptionNextOptionalParams no longer has parameter expand
    Present SDK breaking changes suppressions
    This package has no defined suppressions.
    Absent SDK breaking changes suppressions
    - Class TemplateSpecsClient has a new signature
    - Interface TemplateSpecsListByResourceGroupNextOptionalParams no longer has parameter expand
    - Interface TemplateSpecsListBySubscriptionNextOptionalParams no longer has parameter expand
    Please refer to the guidance for suppressing SDK breaking changes.
️❌ azure-resource-manager-schemas failed [Detail]
    For more instructions, please refer to the FAQ .
  • Code Generator Failed in generating from db0ded437ba3d09f1ee35e98ba07026fbf36e1cd. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh] Submodule 'bicep-types-az' (https://github.com/Azure/bicep-types-az) registered for path 'bicep-types-az'
    cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az'...
    cmderr	[initScript.sh] Submodule 'bicep-types' (https://github.com/Azure/bicep-types) registered for path 'bicep-types-az/bicep-types'
    cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az/bicep-types'...
    cmderr	[initScript.sh] npm notice
    cmderr	[initScript.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.1
    cmderr	[initScript.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.1
    cmderr	[initScript.sh] npm notice To update run: npm install -g npm@10.8.1
    cmderr	[initScript.sh] npm notice
    error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/initScript.sh
    warn	Warning: File azure-resource-manager-schemas_tmp/initOutput.json not found to read. Please re-run the pipeline if the error is transitient error or report this issue through https://aka.ms/azsdk/support/specreview-channel.
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    cmderr	[generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:500
    cmderr	[generateScript.sh]     return new TSError(diagnosticText, diagnosticCodes)
    cmderr	[generateScript.sh]            ^
    cmderr	[generateScript.sh] TSError: ⨯ Unable to compile TypeScript:
    cmderr	[generateScript.sh] cmd/generateall.ts(6,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(10,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(11,18): error TS2307: Cannot find module 'path' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(13,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(14,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(42,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(69,67): error TS7006: Parameter 'x' implicitly has an 'any' type.
    cmderr	[generateScript.sh] cmd/generateall.ts(70,49): error TS7006: Parameter 'f' implicitly has an 'any' type.
    cmderr	[generateScript.sh] cmd/generateall.ts(94,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(105,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(157,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node` and then add 'node' to the types field in your tsconfig.
    cmderr	[generateScript.sh]     at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:500:12)
    cmderr	[generateScript.sh]     at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:504:19)
    cmderr	[generateScript.sh]     at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:739:36)
    cmderr	[generateScript.sh]     at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:955:32)
    cmderr	[generateScript.sh]     at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:1043:43)
    cmderr	[generateScript.sh]     at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
    cmderr	[generateScript.sh]     at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:1046:12)
    cmderr	[generateScript.sh]     at Module.load (node:internal/modules/cjs/loader:1203:32)
    cmderr	[generateScript.sh]     at Function.Module._load (node:internal/modules/cjs/loader:1019:12)
    cmderr	[generateScript.sh]     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
    error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh
    warn	Warning: Package processing is skipped as the SDK generation fails. Please look into the above generation errors or report this issue through https://aka.ms/azsdk/support/specreview-channel.
️⚠️ azure-powershell warning [Detail]
    For more instructions, please refer to the FAQ .
  • ⚠️Warning in generating from db0ded437ba3d09f1ee35e98ba07026fbf36e1cd. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
  • ⚠️Az.resources.DefaultTag [Preview SDK Changes]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Apr 22, 2024

Generated ApiView

Language Package Name ApiView Link
Java azure-resourcemanager-resources-generated https://apiview.dev/Assemblies/Review/69d90a3c09dd41d388271d10f46fbed8?revisionId=9dd2f8657451430693c371209c5c715e
Go sdk/resourcemanager/resources/armchanges There is no API change compared with the previous version
Go sdk/resourcemanager/resources/armdeploymentscripts https://apiview.dev/Assemblies/Review/7baaae1d269a4ed7912f863425ad71a0?revisionId=71e67e4014a945d6b156d0cc8d9868fa
Go sdk/resourcemanager/resources/armdeploymentstacks https://apiview.dev/Assemblies/Review/6313d59674254051ac3edf0447ad74de?revisionId=b79549299eba4a54817ad8feb5f5a234
Go sdk/resourcemanager/resources/armfeatures There is no API change compared with the previous version
Go sdk/resourcemanager/resources/armlinks There is no API change compared with the previous version
Go sdk/resourcemanager/resources/armlocks There is no API change compared with the previous version
Go sdk/resourcemanager/resources/armmanagedapplications There is no API change compared with the previous version
Go sdk/resourcemanager/resources/armpolicy https://apiview.dev/Assemblies/Review/307c195eccc840d1b92e75be6564ba10?revisionId=167c916de7dc43e4b34e4da813d18828
Go sdk/resourcemanager/resources/armresources https://apiview.dev/Assemblies/Review/12843540e3a1467ea73d364496b55308?revisionId=784844f33022410ca06b4524d51dea62
Go sdk/resourcemanager/resources/armsubscriptions There is no API change compared with the previous version
Go sdk/resourcemanager/resources/armtemplatespecs There is no API change compared with the previous version
.Net Azure.ResourceManager.Resources There is no API change compared with the previous version
JavaScript @azure/arm-changes https://apiview.dev/Assemblies/Review/357d9a1c28c440e8a1bd4912e73149e7?revisionId=51ee43fc82a0417ead8aa3dcd91c3182
JavaScript @azure/arm-features https://apiview.dev/Assemblies/Review/cdac4d1c1fa1462bb53e5df0b43b1fd8?revisionId=758e006861f648d981acb2d516def07d
JavaScript @azure/arm-links https://apiview.dev/Assemblies/Review/fab6f39d3aa4438bbcf44202497c232d?revisionId=ca54c1efcef546b5a6f2be001a887a8d
JavaScript @azure/arm-locks https://apiview.dev/Assemblies/Review/5032ea8e14d64cd0adc264676495aba7?revisionId=722aa5fc2fa14b41b0df3cadb0e29ec3
JavaScript @azure/arm-managedapplications https://apiview.dev/Assemblies/Review/13cbf64f04e64947ba72af718bdd91bf?revisionId=dcdca79c719c4a6f9cb96fe05c749a81
JavaScript @azure/arm-policy https://apiview.dev/Assemblies/Review/cda5950570364aba98f6c682240aed30?revisionId=9e3d413c13b04b648118d23b7ff540a5
JavaScript @azure/arm-resources-subscriptions There is no API change compared with the previous version
JavaScript @azure/arm-resources https://apiview.dev/Assemblies/Review/2afa29187fb74b96ba17874edd55e007?revisionId=409c9563d3674fe29ea696d0e6d80e27
JavaScript @azure/arm-resourcesdeploymentstacks https://apiview.dev/Assemblies/Review/adf278a227e04a51b406ca734e90fef9?revisionId=8abbb225d61647afb362696b9bdc2449
JavaScript @azure/arm-templatespecs https://apiview.dev/Assemblies/Review/fc04625bf7df4e6e97f03f7aae3c05b7?revisionId=50f6aaa2f6d3488dbbe3fdd273742fcb
Swagger Microsoft.Resources https://apiview.dev/Assemblies/Review/c6d5ee6adb604c8d98405cc2ea6c8f31?revisionId=e18878e050b3435181e52f73c121aef0

@AzureRestAPISpecReview AzureRestAPISpecReview added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ARMReview BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required new-api-version resource-manager labels Apr 22, 2024
Copy link

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

This was referenced Apr 22, 2024
@Alancere
Copy link
Member

Alancere commented Jul 30, 2024

Hi @raych1, please approve BreakingChange-Go-Sdk-Suppression, the current PR introduces the following Go SDK BreakingChange:

- Field `DeploymentValidateResult` of struct `DeploymentsClientValidateAtManagementGroupScopeResponse` has been removed
- Field `DeploymentValidateResult` of struct `DeploymentsClientValidateAtScopeResponse` has been removed
- Field `DeploymentValidateResult` of struct `DeploymentsClientValidateAtSubscriptionScopeResponse` has been removed
- Field `DeploymentValidateResult` of struct `DeploymentsClientValidateAtTenantScopeResponse` has been removed
- Field `DeploymentValidateResult` of struct `DeploymentsClientValidateResponse` has been removed
- Struct `DeploymentValidateResult` has been removed

DeploymentValidateResult replaced to DeploymentExtended

@ms-bogdan-rotaru
Copy link

@anthony-c-martin This PR cannot be merged due to some failing checks and the branch is out-of-date. Can you please check?

@kazrael2119
Copy link
Contributor

kazrael2119 commented Jul 30, 2024

add BreakingChange-JavaScript-Sdk to remove the block caused by the breaking change of other RPs

@ms-bogdan-rotaru
Copy link

@kazrael2119 Can you also check the Swagger PrettierCheck check?

@rkmanda
Copy link
Member

rkmanda commented Aug 2, 2024

pl fix the prettier check, resolve the branch conflicts and then request merge again

@jorgecotillo
Copy link
Contributor Author

@rkmanda when I ran prettier check following the cmd mentioned in the GH check I got no violations locally, I mentioned it some time ago: #28788 (comment)

@tsmallig33
Copy link
Contributor

/pr RequestMerge

@anthony-c-martin
Copy link
Member

/pr RequestMerge

@tsmallig33 tsmallig33 added PublishToCustomers Acknowledgement the changes will be published to Azure customers. MergeRequested labels Aug 8, 2024
@rkmanda rkmanda merged commit 4405182 into Azure:main Aug 10, 2024
27 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior BreakingChange-Go-Sdk-Suppression BreakingChange-Go-Sdk-Suppression-Approved BreakingChange-JavaScript-Sdk BreakingChange-JavaScript-Sdk-Approved BreakingChange-JavaScript-Sdk-Suppression BreakingChange-JavaScript-Sdk-Suppression-Approved BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required new-api-version PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.