Add Azure Red Hat OpenShift 2024-08-12-preview #29671
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Swagger Validation Report
|
| Compared specs (v0.10.12) | new version | base version |
|---|---|---|
| redhatopenshift.json | 2024-08-12-preview(4c825bc) | 2023-11-22(main) |
| redhatopenshift.json | 2024-08-12-preview(4c825bc) | 2023-07-01-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
| Rule | Message |
|---|---|
|
The new version is missing a 'x-ms-enum' found in the old version. New: openshiftclusters/preview/2024-08-12-preview/redhatopenshift.json#L1906:9 Old: common-types/resource-management/v3/types.json#L214:9 |
The following breaking changes are detected by comparison with the latest preview version:
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌LintDiff: 1 Errors, 1 Warnings failed [Detail]
| Compared specs (v2.2.2) | new version | base version |
|---|---|---|
| package-2023-07-01-preview | package-2023-07-01-preview(4c825bc) | default(main) |
| package-2023-11-22 | package-2023-11-22(4c825bc) | default(main) |
| package-2024-08-12-preview | package-2024-08-12-preview(4c825bc) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
|
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: openshiftclusters/preview/2024-08-12-preview/redhatopenshift.json#L2625 |
RPC-Policy-V1-05, RPC-Put-V1-23 |
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Creates or updates a OpenShift cluster with the specified subscription, resource group and resource name. Location: openshiftclusters/preview/2024-08-12-preview/redhatopenshift.json#L602 |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
️❌Avocado: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
The default tag does not contains the latest API version. Please make sure the latest api version swaggers are in the default tag. readme: resource-manager/Microsoft.RedHatOpenShift/openshiftclusters/readme.md json: openshiftclusters/stable/2023-11-22/redhatopenshift.json |
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
This was referenced Jul 2, 2024
AzureRestAPISpecReview
added
BreakingChangeReviewRequired
|
/azp run |
|
Commenter does not have sufficient privileges for PR 29671 in repo Azure/azure-rest-api-specs |
cadenmarchese
force-pushed
the
add-20240812preview
branch
2 times, most recently
from
6eae328
to
219ece6
Compare
AzureRestAPISpecReview
removed
the
BreakingChangeReviewRequired
cadenmarchese
force-pushed
the
add-20240812preview
branch
from
5adb5a0
to
154e0a4
Compare
AzureRestAPISpecReview
added
ARMReview
new-api-version
ReadyForApiTest
|
The first commit needs to be an exact copy of the previous API version. All new changes should only be added in the subsequent commits. |
ms-bogdan-rotaru
added
the
ARMChangesRequested
openapi-pipeline-app
bot
removed
the
WaitForARMFeedback
|
@ms-bogdan-rotaru hi, thanks for your review. I've opened #30004 which has the commits ordered in that way. The API changes should be visible between the first and second commits. I'll close this PR in favor of that one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PRandDue diligence checklist.write accessper aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.