Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQ] @CosmosIndexingPolicy in spring-data-cosmos should support composite, range, and spatial indexes #17535

Closed
2 tasks done
Blackbaud-EricSlater opened this issue Nov 12, 2020 · 8 comments
Assignees
Labels
azure-spring-cosmos Spring cosmos related issues. Client This issue points to a problem in the data-plane of the library. Cosmos cosmos-java-ecosystem-dt-planning Considered for Dilithium semester planning customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that

Comments

@Blackbaud-EricSlater
Copy link
Contributor

Blackbaud-EricSlater commented Nov 12, 2020

Is your feature request related to a problem? Please describe.
spring-data-cosmos @CosmosIndexingPolicy does not support specifying composite indexes, spatial indexes, or range indexes

Describe the solution you'd like
Extend the @CosmosIndexingPolicy annotation to support all of the above.

Specifically a compositeIndexes field should be added to support specifying json like this...

"compositeIndexes":[  
            [  
                {  
                    "path":"/name",
                    "order":"ascending"
                },
                {  
                    "path":"/age",
                    "order":"descending"
                }
            ]
        ]

A spatialIndexes field should be added to support specifying json like this...

    "spatialIndexes": [
        {
            "path": "/path/to/geojson/property/?",
            "types": [
                "Point",
                "Polygon",
                "MultiPolygon",
                "LineString"
            ]
        }
    ]

The includedPaths field should be extended to support range indexes like this...

          {
               "path": "/path/to/included/property/?",
               "indexes": [
                   {
                       "kind": "Range",
                       "dataType": "Number"
                   },
                   {
                       "kind": "Range",
                       "dataType": "String"
                   }
               ]
           }

Describe alternatives you've considered
The sdk itself doesnt provide any alternative. The underlying lib azure-cosmos does seem to provide classes that support specifying range and spatial indexes, though i dont see support for composite indexes.

Additional context
Add any other context or screenshots about the feature request here.

Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

  • Description Added
  • Expected solution specified
@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Nov 12, 2020
@ghost
Copy link

ghost commented Nov 12, 2020

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @kushagraThapar, @anfeldma-ms

@kushagraThapar
Copy link
Member

@mbhaskar - please take a look at this.

@joshfree joshfree added Client This issue points to a problem in the data-plane of the library. Cosmos labels Nov 13, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 13, 2020
@MortezaDamavandpeyma-TomTom

Hi, Is there any update when this will be fixed in azure-spring-data-cosmos sdk? Thanks!

@kushagraThapar
Copy link
Member

@MortezaDamavandpeyma-TomTom - Isn't this already supported?

@kushagraThapar
Copy link
Member

@Blackbaud-EricSlater - we should close this issue if all of the above has been supported, to avoid confusion.

@Blackbaud-EricSlater
Copy link
Contributor Author

only composite indexes support has been added. spatial and range index support has not as far as i know

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-java that referenced this issue Feb 16, 2022
Microsoft.App version 2022-01-01-preview (Azure#17820)

* New Swagger Spec File

* New Swagger Example Spec File

* New Readme Config File

* New Azure AZ Readme Config File

* New Azure CLI Readme Config File

* New Go Language Readme Config File

* New Python Language Readme Config File

* New Typescript Language Readme Config File

* New C# Language Readme Config File

* Adding new API version 2022-01-01-preview for the new service Microsoft.App (Azure#17135)

* Adding swagger and examples

* Fix samples

* Fix linting errors

* fix errors

* fix more errors

* prettier fixes

* Fix the VNET properties

* fix the vnet props

* Attempt to remove x-ms-identifiers

* Add x-ms-identifiers back

* Revert "Add x-ms-identifiers back"

This reverts commit 44525ab5ace45d9cb1bc85bee2751f015dcaffc6.

* Addsourcecontrolapis (Azure#17287)

* add sourcecontrol apis

* remove space

* prettier fix

* typo

* avocado fix

* lint fix

* add replicas apis (Azure#17501)

* Remove Dapr components from ContainerApp spec. Not breaking because the version hasn't been released yet. (Azure#17479)

* Remove dapr components from the ContainerApp object

* Fix example

* add descriptions

* fix

* change the auto-rest parameters

* Support volume mounts for containerApp (Azure#17530)

* add volume mounts

* add identifier

* refine volume definition

* Fix samples (Azure#17534)

* Adding managed identity (Azure#17569)

* Adding managed identity

* prettier fix.

* Microsof.app 2022 01 01 preview/add custom domains (Azure#17385)

* add support for Custom domains and certificates

* add Certificates

* Ccertificate as child resource of Managed Env.

* Support default custom domain

* PUT/DELETE certificate are not long-running

* Add Custom Domain Verification Id

* domains for all revisions and adding examples

* missing examples

* one more missing example

* Examples+missing paths

* Adding missing envelope properties

* Addressing PR comments

* Removing AKV and Free cert related properties

* Prettier and semantic validation fixes

* Fixing semantic validations and examples

* More fixes

* Addressing more PR comments

* Updating examples

* fixing type

* fixing types

* Extra properties and responses

* misplaced response

* whitespace

* fix security section

* fixing ManageEnvironment securityDefinitions

* add 204 delete response

* Removing virtual IP and IP Based option

* change modelAsString

* Addressing ARM PR comments

* Removing 404 response from example

* renaming custom hostname analysis operation

* mark certificate as tracked resource

* fix sample

* Use Certificate Id instead of Certificate name

Co-authored-by: Ruslan Yakushev 🚴 <ruslany@microsoft.com>
Co-authored-by: vinisoto <vinisoto@hotmail.com>

* Add new properties for ContainerApp (Azure#17483)

* add ephemeral storage

* add outbound ip

* add listsecrets

* fix CI

* fix example

* fix

* add identifier

* fix

* add example

* mars as secret

* Add storages operation for managedEnvironment (Azure#17545)

* add storage

* fix

* fix typo

* Add EasyAuth configuration APIs for ContainerApp (Azure#17492)

* Add Easy Auth Config related APIs for ContainerApp

* Use common type ProxyResource

* Update description

* update per validation

* typo fix

* fix validation error

* Update sample and description

* Update because ARM prefer string than boolean

* Add static web identity provider

* Add container probes (Azure#17535)

* Add container probes

* minor fix

* Use execute instead of exec'd, add identifier

* remove exec from preview

* use integer instead of intorstring

* Add `internal` property under VnetConfiguration for internalOnly environments (Azure#17656)

* Add internal property under VnetConfiguration for internalOnly environments

* Update examples

* Add Dapr Components collection APIs (Azure#17552)

* Add daprComponents

* update readme

* Fix linting errors

* More lint fixes

* prettier fixes

* make dapr component a tracked resource

* fix the patch

* fix lint errors

* Revert "fix lint errors"

This reverts commit 045f1d94bddf3527eab98b7a376070ab30fdd760.

* Revert "fix the patch"

This reverts commit 14521103e848e09762185f832c0270c16ed16efd.

* Revert "make dapr component a tracked resource"

This reverts commit 239268eda070ff37f26e8a772adacdd26bbf0937.

* Fix linter issues

* fix wrong fix

* fix linter

* fix the operationids (Azure#17809)

* correct resource name (Azure#17846)

* Add custom open id providers support (Azure#17855)

* Add custom open id providers support

* Update description

Co-authored-by: Xingjian Wang <79332479+xwang971@users.noreply.github.com>
Co-authored-by: Zunli Hu <zuh@microsoft.com>
Co-authored-by: Vaclav Turecek <vturecek@microsoft.com>
Co-authored-by: Vini Soto <18271663+vinisoto@users.noreply.github.com>
Co-authored-by: vinisoto <vinisoto@hotmail.com>
Co-authored-by: erich-wang <eriwan@microsoft.com>
Co-authored-by: Mike Vu <mdhvu@uwaterloo.ca>
Co-authored-by: Sanchit Mehta <sanmeht@microsoft.com>
@xinlian12 xinlian12 added the azure-spring-cosmos Spring cosmos related issues. label Jun 13, 2022
@ghost ghost added the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Jun 13, 2022
@trande4884 trande4884 self-assigned this Aug 9, 2022
@TheovanKraay
Copy link
Member

We will review adding of spatial and range index support in upcoming semester planning (October).

@kushagraThapar kushagraThapar added cosmos-java-ecosystem-dt-planning Considered for Dilithium semester planning and removed cosmos-java-ecosystem-zn labels Mar 8, 2024
Copy link

github-actions bot commented Apr 8, 2024

Hi @Blackbaud-EricSlater, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 8, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
azure-spring-cosmos Spring cosmos related issues. Client This issue points to a problem in the data-plane of the library. Cosmos cosmos-java-ecosystem-dt-planning Considered for Dilithium semester planning customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
None yet
Development

No branches or pull requests

8 participants