Use Default DNS Resolver when Creating a New HttpClient #22661
Conversation
alzimmermsft
added
Client
alzimmermsft
requested review from
anuchandy,
jianghaolu,
lmolkova and
srnagar
as code owners
...ure-core-http-netty/src/main/java/com/azure/core/http/netty/NettyAsyncHttpClientBuilder.java
Show resolved
Hide resolved
| @@ -92,9 +93,9 @@ public NettyAsyncHttpClientBuilder(HttpClient nettyHttpClient) { | |||
| if (this.baseHttpClient != null) { | |||
| nettyHttpClient = baseHttpClient; | |||
| } else if (this.connectionProvider != null) { | |||
| nettyHttpClient = HttpClient.create(this.connectionProvider); | |||
| nettyHttpClient = HttpClient.create(this.connectionProvider).resolver(DefaultAddressResolverGroup.INSTANCE); | |||
There was a problem hiding this comment.
Is this not supported in OkHttp?
There was a problem hiding this comment.
It is possible to configure the DNS resolver in OkHttp as well but it doesn't run into the same issue being seen with Reactor Netty.
There was a problem hiding this comment.
Since this is applicable to all HTTP clients, is this something we should put on HttpClientOptions so that the user doesn't have to go build their own HTTP client when they have to configure this?
There was a problem hiding this comment.
Issue is that the types being used aren't in the base Java library so there will need to be a wrapper interface
|
@alzimmermsft Hello Alan, this is causing my application to be unable to connect to the azure keyvault (who's behind a corporate proxy). Before your fix, the http client resolver was null, and later in the same class initialized with an NoopAddressResolver. Because of this fix, this is not happening anymore. In other words, this code that was executed before the fix is not anymore :) Is this a regression, or is there something else I should be doing? Thanks ! |
Fixes #22618
Updates
NettyAsyncHttpClientBuilderto use the default DNS resolver when anHttpClientinstance is being created without an initial underlying Netty HTTP client. This resolves an issue where the first request made in an application has a much higher completion time (>10s) compared to subsequent requests (generally in ms).