-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AsyncCacheNonBlocking - Improve availability during replica movement #29322
AsyncCacheNonBlocking - Improve availability during replica movement #29322
Conversation
...azure-cosmos/src/main/java/com/azure/cosmos/implementation/caches/AsyncCacheNonBlocking.java
Outdated
Show resolved
Hide resolved
...azure-cosmos/src/main/java/com/azure/cosmos/implementation/caches/AsyncCacheNonBlocking.java
Outdated
Show resolved
Hide resolved
...azure-cosmos/src/main/java/com/azure/cosmos/implementation/caches/AsyncCacheNonBlocking.java
Show resolved
Hide resolved
...azure-cosmos/src/main/java/com/azure/cosmos/implementation/caches/AsyncCacheNonBlocking.java
Show resolved
Hide resolved
...azure-cosmos/src/main/java/com/azure/cosmos/implementation/caches/AsyncCacheNonBlocking.java
Outdated
Show resolved
Hide resolved
...azure-cosmos/src/main/java/com/azure/cosmos/implementation/caches/AsyncCacheNonBlocking.java
Outdated
Show resolved
Hide resolved
...azure-cosmos/src/main/java/com/azure/cosmos/implementation/caches/AsyncCacheNonBlocking.java
Outdated
Show resolved
Hide resolved
...azure-cosmos/src/main/java/com/azure/cosmos/implementation/caches/AsyncCacheNonBlocking.java
Outdated
Show resolved
Hide resolved
...azure-cosmos/src/main/java/com/azure/cosmos/implementation/caches/AsyncCacheNonBlocking.java
Outdated
Show resolved
Hide resolved
...azure-cosmos/src/main/java/com/azure/cosmos/implementation/caches/AsyncCacheNonBlocking.java
Outdated
Show resolved
Hide resolved
...azure-cosmos/src/main/java/com/azure/cosmos/implementation/caches/AsyncCacheNonBlocking.java
Outdated
Show resolved
Hide resolved
...azure-cosmos/src/main/java/com/azure/cosmos/implementation/caches/AsyncCacheNonBlocking.java
Outdated
Show resolved
Hide resolved
...azure-cosmos/src/main/java/com/azure/cosmos/implementation/caches/AsyncCacheNonBlocking.java
Outdated
Show resolved
Hide resolved
...azure-cosmos/src/main/java/com/azure/cosmos/implementation/caches/AsyncCacheNonBlocking.java
Outdated
Show resolved
Hide resolved
...re-cosmos/src/main/java/com/azure/cosmos/implementation/caches/RxPartitionKeyRangeCache.java
Show resolved
Hide resolved
...cosmos/azure-cosmos/src/test/java/com/azure/cosmos/AsyncCacheNonBlockingIntegrationTest.java
Show resolved
Hide resolved
...e-cosmos/src/test/java/com/azure/cosmos/implementation/caches/AsyncCacheNonBlockingTest.java
Show resolved
Hide resolved
...e-cosmos/src/test/java/com/azure/cosmos/implementation/caches/AsyncCacheNonBlockingTest.java
Show resolved
Hide resolved
...azure-cosmos/src/main/java/com/azure/cosmos/implementation/caches/AsyncCacheNonBlocking.java
Outdated
Show resolved
Hide resolved
...azure-cosmos/src/main/java/com/azure/cosmos/implementation/caches/AsyncCacheNonBlocking.java
Show resolved
Hide resolved
...azure-cosmos/src/main/java/com/azure/cosmos/implementation/caches/AsyncCacheNonBlocking.java
Outdated
Show resolved
Hide resolved
...azure-cosmos/src/main/java/com/azure/cosmos/implementation/caches/AsyncCacheNonBlocking.java
Outdated
Show resolved
Hide resolved
...azure-cosmos/src/main/java/com/azure/cosmos/implementation/caches/AsyncCacheNonBlocking.java
Outdated
Show resolved
Hide resolved
...azure-cosmos/src/main/java/com/azure/cosmos/implementation/caches/AsyncCacheNonBlocking.java
Outdated
Show resolved
Hide resolved
...azure-cosmos/src/main/java/com/azure/cosmos/implementation/caches/AsyncCacheNonBlocking.java
Show resolved
Hide resolved
...re-cosmos/src/main/java/com/azure/cosmos/implementation/caches/RxPartitionKeyRangeCache.java
Outdated
Show resolved
Hide resolved
...re-cosmos/src/main/java/com/azure/cosmos/implementation/caches/RxPartitionKeyRangeCache.java
Outdated
Show resolved
Hide resolved
/azp run java - cosmos - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run java - cosmos - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run java - cosmos - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run java - cosmos - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
...azure-cosmos/src/main/java/com/azure/cosmos/implementation/caches/AsyncCacheNonBlocking.java
Outdated
Show resolved
Hide resolved
...azure-cosmos/src/main/java/com/azure/cosmos/implementation/caches/AsyncCacheNonBlocking.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - except for few NITs aroung logging and isDebugEnabled check
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
…zure#29322) * Async Non Blocking Cache * Async Non Blocking Cache * Resolving comments * Resolving spotbugs * Fixing spot bugs * Resolving comments * Fixing spot bugs * Resolving comments * Fixing CI build * Resolving comments
…zure#29322) * Async Non Blocking Cache * Async Non Blocking Cache * Resolving comments * Resolving spotbugs * Fixing spot bugs * Resolving comments * Fixing spot bugs * Resolving comments * Fixing CI build * Resolving comments
Description
The current AsyncCache on force refreshes removes the value. It then creates a new value and all incoming requests are stuck waiting for the new task to complete.
Issue
If a single replica moves only 1 of the 4 replicas URIs is stale. The current async cache is blocking all requests until the value is updated. The 3 other replicas could be used to successfully complete requests.
Solution
AsyncCacheNonBlocking was created. This async cache does not block requests on refresh. It instead returns the stale value until the refresh is complete. Then the refresh value is used to update the cache. Any request using the forceRefresh to true will wait on the same refresh task.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines
Benchmark Workload in Prod on West US 2 during upgrades
Workload Test RU: 100,000 Documents: 100,000 Time Duration: 60 hrs Region: West US 2*
Throughput - Mean Rate
Throughput - m5 Rate
Latency - p95
Latency - p99
Latency - p999
Latency - max
Benchmark Test RU: 100,000, Documents: 100,000, Region: South Central US**
Throughput:
P95 Latency
P99 Latency
P999 Latency
Max Latency