Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure HttpClientOptions is passed fully to HttpClientBuilders #31079

Merged
merged 5 commits into from
Sep 21, 2022
Merged

Ensure HttpClientOptions is passed fully to HttpClientBuilders #31079

merged 5 commits into from
Sep 21, 2022

Conversation

alzimmermsft
Copy link
Member

Description

Fixes #31051

Ensures that HttpClientOptions, that are applicable to the HttpClient implementation, are being passed correctly to the HttpClientBuilder from the HttpClientProvider. Additionally renames JdkAsyncHttpClientBuilder to JdkHttpClientBuilder to match the naming of JdkHttpClient.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@alzimmermsft alzimmermsft added Client This issue points to a problem in the data-plane of the library. Azure.Core azure-core HttpClient labels Sep 21, 2022
@alzimmermsft alzimmermsft self-assigned this Sep 21, 2022
@alzimmermsft alzimmermsft mentioned this pull request Sep 21, 2022
Closed
3 tasks
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-core-http-jdk-httpclient

lmolkova
lmolkova approved these changes Sep 21, 2022
View reviewed changes
Copy link
Member

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alzimmermsft
Copy link
Member Author

/check-enforcer override

@alzimmermsft
Copy link
Member Author

Linting pipeline is failing due to a change outside of the PR

@alzimmermsft alzimmermsft merged commit a60a5e6 into Azure:main Sep 21, 2022
@alzimmermsft alzimmermsft deleted the AzHttp_EnsureHttpClientOptionsArePassed branch September 21, 2022 20:16
fangjian0423 pushed a commit to fangjian0423/azure-sdk-for-java that referenced this pull request Sep 27, 2022
@alzimmermsft @fangjian0423
Ensure HttpClientOptions is passed fully to HttpClientBuilders (Azure…
9507e21 
…#31079)

Ensure HttpClientOptions is passed fully to HttpClientBuilders
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmolkova lmolkova lmolkova approved these changes

@mssfang mssfang Awaiting requested review from mssfang mssfang is a code owner

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles JonathanGiles is a code owner

@srnagar srnagar Awaiting requested review from srnagar srnagar is a code owner

@anuchandy anuchandy Awaiting requested review from anuchandy anuchandy is a code owner

@vcolin7 vcolin7 Awaiting requested review from vcolin7 vcolin7 is a code owner

@billwert billwert Awaiting requested review from billwert billwert is a code owner

Assignees

@alzimmermsft alzimmermsft

Labels
Azure.Core azure-core Client This issue points to a problem in the data-plane of the library. HttpClient
Projects
None yet
Milestone
No milestone
3 participants
@alzimmermsft @azure-sdk @lmolkova