Read many optimization #31723

jeet1995 · 2022-10-25T19:37:57Z

Description

This PR optimizes readMany to make use of point reads when only a single item is requested from a physical partition.

All SDK Contribution checklist:

The pull request does not introduce [breaking changes]
CHANGELOG is updated for new features, bug fixes or other significant changes.
I have read the contribution guidelines.

General Guidelines and Best Practices

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

Benchmarking

Averages

P99 (main)	P99 (optimization)	P99.9 (main)	P99.9 (optimization)	Throughput - mean rate (main)	Throughput - mean rate (optimization)	Tuple Size	No. of documents
4.83 ms	4.77 ms	7.79 ms	7.73 ms	1738.92 events/s	2104.25 events/s	1	1000
8.97 ms	6.99 ms	13.42 ms	11.17 ms	1114.26 events/s	1490.02 events/s	5	1000

…equests

…into ReadManyOptimization

jeet1995 · 2022-10-25T22:16:17Z

/azp run java - cosmos - tests

azure-pipelines · 2022-10-25T22:16:33Z

Azure Pipelines successfully started running 1 pipeline(s).

sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RxDocumentClientImpl.java

jeet1995 · 2022-11-13T20:15:22Z

/azp run java - cosmos - tests

azure-pipelines · 2022-11-13T20:15:34Z

Azure Pipelines successfully started running 1 pipeline(s).

…into ReadManyOptimization

…anyOptimization

azure-sdk · 2022-11-27T17:13:27Z

API change check

API changes are not detected in this pull request.

…anyOptimization � Conflicts: � sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/CosmosItemTest.java

…anyOptimization � Conflicts: � sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RxDocumentClientImpl.java

jeet1995 · 2022-12-01T22:46:25Z

/azp run java - cosmos - tests

azure-pipelines · 2022-12-01T22:46:38Z

Azure Pipelines successfully started running 1 pipeline(s).

kushagraThapar

Great work @jeet1995, good tests, thanks!
Minor suggestions / questions.

.../azure-cosmos-benchmark/src/main/java/com/azure/cosmos/benchmark/AsyncReadManyBenchmark.java

sdk/cosmos/azure-cosmos-benchmark/src/main/java/com/azure/cosmos/benchmark/Configuration.java

sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RxDocumentClientImpl.java

jeet1995 · 2022-12-08T14:35:24Z

/azp run java - cosmos - tests

azure-pipelines · 2022-12-08T14:35:39Z

Azure Pipelines successfully started running 1 pipeline(s).

jeet1995 · 2022-12-08T23:23:45Z

/check-enforcer override

jeet1995 · 2022-12-08T23:29:10Z

/check-enforcer override

jeet1995 added 15 commits October 13, 2022 19:45

added functionality to choose point reads for single item partition r…

0baa23d

…equests

added transformations for CosmosQueryRequestOptions and ResourceResponse

a0c0158

refactor

ce351b5

added functionality to choose point reads for single item partition r…

7e5de0f

…equests

refactor

df8ace8

added tests

64546ab

Merge branch 'main' of https://github.com/jeet1995/azure-sdk-for-java …

b200ec1

…into ReadManyOptimization

reformat

09926a9

added tests

5c50387

added diagnostics to aggregated feed response

1468356

replaced var with explicit type

975165a

enhanced unit tests

7f5564b

Merge branch 'main' of https://github.com/jeet1995/azure-sdk-for-java …

62d0b9f

…into ReadManyOptimization

enhanced unit tests

9dc3601

enhanced unit tests

758ae8b

jeet1995 requested review from kushagraThapar, FabianMeiswinkel, kirankumarkolli, xinlian12, milismsft, aayush3011 and simorenoh as code owners October 25, 2022 19:37

ghost added the Cosmos label Oct 25, 2022

jeet1995 added 4 commits October 25, 2022 15:39

updated CHANGELOG.md

d93d0d1

attempt at fixing failing build

5b3705c

attempt at fixing failing build

f6a74ce

attempt at fixing failing build

56bb580

kirankumarkolli reviewed Oct 25, 2022

View reviewed changes

sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RxDocumentClientImpl.java Outdated Show resolved Hide resolved

jeet1995 added 4 commits November 8, 2022 18:56

added test for request charge comparison

9577bb2

removed unused imports

49944a0

revert

f91a755

Merge branch 'Azure:main' into ReadManyOptimization

26f5529

jeet1995 requested a review from Pilchie as a code owner November 13, 2022 20:14

jeet1995 added 5 commits November 14, 2022 23:07

Merge branch 'main' of https://github.com/jeet1995/azure-sdk-for-java …

c2bfa10

…into ReadManyOptimization

Merge remote-tracking branch 'upstream/main' into ReadManyOptimization

7e748d9

Fix leaky abstraction

8181488

Merge branch 'main' of github.com:Azure/azure-sdk-for-java into ReadM…

864ba71

…anyOptimization

Merge remote-tracking branch 'origin/ReadManyOptimization' into ReadM…

4ddb949

…anyOptimization

jeet1995 added 4 commits November 29, 2022 16:22

Added tupleSize for readMany-specific benchmarking

7e9160f

Merge branch 'main' of github.com:Azure/azure-sdk-for-java into ReadM…

2105a29

…anyOptimization � Conflicts: � sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/CosmosItemTest.java

Merge branch 'main' of github.com:Azure/azure-sdk-for-java into ReadM…

c851dab

…anyOptimization � Conflicts: � sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RxDocumentClientImpl.java

Add tupleSize for readMany-specific benchmarking

1583200

jeet1995 requested a review from kushagraThapar December 6, 2022 15:44

kushagraThapar approved these changes Dec 7, 2022

View reviewed changes

jeet1995 and others added 2 commits December 7, 2022 15:24

Addressed review comments

3c472a5

Added code changes for few code review comments on renaming

99de52e

kushagraThapar approved these changes Dec 7, 2022

View reviewed changes

Update CHANGELOG.md

060a0b3

jeet1995 merged commit d836145 into Azure:main Dec 8, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Read many optimization #31723

Read many optimization #31723

jeet1995 commented Oct 25, 2022 •

edited

Loading

jeet1995 commented Oct 25, 2022

azure-pipelines bot commented Oct 25, 2022

jeet1995 commented Nov 13, 2022

azure-pipelines bot commented Nov 13, 2022

azure-sdk commented Nov 27, 2022

jeet1995 commented Dec 1, 2022

azure-pipelines bot commented Dec 1, 2022

kushagraThapar left a comment

jeet1995 commented Dec 8, 2022

azure-pipelines bot commented Dec 8, 2022

jeet1995 commented Dec 8, 2022

jeet1995 commented Dec 8, 2022

Read many optimization #31723

Read many optimization #31723

Conversation

jeet1995 commented Oct 25, 2022 • edited Loading

Description

All SDK Contribution checklist:

General Guidelines and Best Practices

Testing Guidelines

Benchmarking

Averages

jeet1995 commented Oct 25, 2022

azure-pipelines bot commented Oct 25, 2022

jeet1995 commented Nov 13, 2022

azure-pipelines bot commented Nov 13, 2022

azure-sdk commented Nov 27, 2022

jeet1995 commented Dec 1, 2022

azure-pipelines bot commented Dec 1, 2022

kushagraThapar left a comment

Choose a reason for hiding this comment

jeet1995 commented Dec 8, 2022

azure-pipelines bot commented Dec 8, 2022

jeet1995 commented Dec 8, 2022

jeet1995 commented Dec 8, 2022

jeet1995 commented Oct 25, 2022 •

edited

Loading