Allow tracer with client metrics #32787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tMetricsEnabled is true
theonajim
requested review from
kushagraThapar,
FabianMeiswinkel,
kirankumarkolli,
xinlian12,
milismsft,
aayush3011,
simorenoh,
jeet1995 and
Pilchie
as code owners
ghost
added
Cosmos
customer-reported
|
Thank you for your contribution theonajim! We will review the pull request and get back to you soon. |
|
@microsoft-github-policy-service agree company="walmart" |
kushagraThapar
approved these changes
Jan 5, 2023
There was a problem hiding this comment.
LGTM, thanks a lot @theonajim
Let's also get a review from @FabianMeiswinkel
conniey
pushed a commit
to conniey/azure-sdk-for-java
that referenced
this pull request
Jan 30, 2023
…tMetricsEnabled is true (Azure#32787) Co-authored-by: Theo Najim <tnajim@walmartlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TraceProvider constructor inadvertently disables tracing when isClientMetricsEnabled is true
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines