Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Confidential Ledger] Fix the test pipeline failure #33585

Merged
4 commits merged into from
Feb 17, 2023

Conversation

mniamme
Copy link
Member

@mniamme mniamme commented Feb 17, 2023

Description

This PR fixes the failing test pipeline for the Azure Confidential Ledger service.

@ghost
Copy link

ghost commented Feb 17, 2023

Hello @Xamrmo!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Copy link
Member

@vcolin7 vcolin7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things LGTM. I just left a small comment on the region.

"type": "string",
"metadata": {
"description": "Oid of the user"
}
},
"location": {
"type": "string",
"defaultValue": "[resourceGroup().location]",
"defaultValue": "eastus",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a specific reason we are hard-coding the region?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ResourceGroup().location returns westus and this isn't supported yet by the service.

@ghost ghost merged commit f9fd6f6 into Azure:main Feb 17, 2023
@mniamme mniamme deleted the fix_test_pipeline branch February 20, 2023 14:42
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants