[Confidential Ledger] Fix the test pipeline failure #33585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mniamme
requested review from
joshfree,
srnagar,
anuchandy,
conniey,
lmolkova and
JonathanGiles
as code owners
|
Hello @Xamrmo! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
API change check API changes are not detected in this pull request. |
vcolin7
approved these changes
Feb 17, 2023
| "type": "string", | ||
| "metadata": { | ||
| "description": "Oid of the user" | ||
| } | ||
| }, | ||
| "location": { | ||
| "type": "string", | ||
| "defaultValue": "[resourceGroup().location]", | ||
| "defaultValue": "eastus", |
There was a problem hiding this comment.
Is there a specific reason we are hard-coding the region?
There was a problem hiding this comment.
ResourceGroup().location returns westus and this isn't supported yet by the service.
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the failing test pipeline for the Azure Confidential Ledger service.