Fixing an issue with Direct Channels acquired/close metrics for idle endpoints #33969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabianMeiswinkel
requested review from
kushagraThapar,
kirankumarkolli,
xinlian12,
milismsft,
aayush3011,
simorenoh,
jeet1995 and
Pilchie
as code owners
ghost
added
the
xinlian12
reviewed
Mar 11, 2023
xinlian12
reviewed
Mar 11, 2023
...va/com/azure/cosmos/implementation/directconnectivity/rntbd/RntbdDurableEndpointMetrics.java
Show resolved
Hide resolved
xinlian12
reviewed
Mar 11, 2023
...main/java/com/azure/cosmos/implementation/directconnectivity/rntbd/RntbdServiceEndpoint.java
Outdated
Show resolved
Hide resolved
xinlian12
reviewed
Mar 11, 2023
...main/java/com/azure/cosmos/implementation/directconnectivity/rntbd/RntbdServiceEndpoint.java
Outdated
Show resolved
Hide resolved
|
API change check API changes are not detected in this pull request. |
|
Thanks for the fix. Can we merge it into March's release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Metrics emitted for Direct Channels acquired/close have an issue when RntbdServiceEndpoints get evicted (because an idle timeout for endpoints is hit). To fix it we need to make the direct metrics durable between different RntbdServiceEndpoint instances for the same endpoint URI.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines