-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Applying diagnostic thresholds for request-level metrics #35114
Merged
FabianMeiswinkel
merged 6 commits into
Azure:main
from
FabianMeiswinkel:users/fabianm/RequestMetricsWithThreshold
May 24, 2023
Merged
Applying diagnostic thresholds for request-level metrics #35114
FabianMeiswinkel
merged 6 commits into
Azure:main
from
FabianMeiswinkel:users/fabianm/RequestMetricsWithThreshold
May 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to users/fabianm/RequestMetricsWithThreshold
FabianMeiswinkel
requested review from
kushagraThapar,
kirankumarkolli,
xinlian12,
milismsft,
aayush3011,
simorenoh,
jeet1995 and
Pilchie
as code owners
May 23, 2023 09:09
API change check APIView has identified API level changes in this PR and created following API reviews. |
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/models/CosmosClientTelemetryConfig.java
Outdated
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/models/CosmosMicrometerMeterOptions.java
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/models/CosmosMicrometerMeterOptions.java
Outdated
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/models/CosmosMicrometerMeterOptions.java
Show resolved
Hide resolved
...osmos/azure-cosmos/src/main/java/com/azure/cosmos/models/CosmosMicrometerMetricsOptions.java
Show resolved
Hide resolved
FabianMeiswinkel
changed the title
Draft: Applying diagnostic thresholds for request-level metrics
Applying diagnostic thresholds for request-level metrics
May 23, 2023
kushagraThapar
approved these changes
May 24, 2023
xinlian12
reviewed
May 24, 2023
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/ClientMetricsTest.java
Outdated
Show resolved
Hide resolved
xinlian12
reviewed
May 24, 2023
...os/src/main/java/com/azure/cosmos/implementation/clienttelemetry/ClientTelemetryMetrics.java
Show resolved
Hide resolved
xinlian12
reviewed
May 24, 2023
...os/src/main/java/com/azure/cosmos/implementation/clienttelemetry/ClientTelemetryMetrics.java
Show resolved
Hide resolved
xinlian12
reviewed
May 24, 2023
...os/src/main/java/com/azure/cosmos/implementation/clienttelemetry/ClientTelemetryMetrics.java
Show resolved
Hide resolved
xinlian12
approved these changes
May 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the option to filter request-level metrics via Diagnostics Thresholds. Request-level metrics use a dimension for the Service Endpoint / and/or Replica - s0, they allow to help debugging any transport/backend related issues - because they can help identify whether connectivity issues and/or high latency are constrained to a certain backend endpoint or not. For workloads with large containers (using hundreds of physical partitions) this means very high cardinality dimensions on those metrics - which can put a lot of pressure on the monitoring system due the high number of timeseries stored for these metrics. The filtering by diagnostics thresholds will reduce the overhead here significantly, because request-level metrics will be sampled and only be emitted when operations violate the expected thresholds (latency, RU charge etc.) - so, they are available to debug any threshold violations - but the cardinality will be lower at least when these threshold violations don't happen across all service endpoints / backend replica simultaneously - in which case that is a clear sign that the problem is on the client-side.
How to enable diagnostic threshold sampling for request-level metrics?
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines