-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read many fix #35513
Read many fix #35513
Conversation
API change check API changes are not detected in this pull request. |
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/CosmosItemTest.java
Outdated
Show resolved
Hide resolved
/azp run java - cosmos - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/CosmosItemTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks
/azp run java - cosmos - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
There are some metric-related tests which don't pass - would require some looking at. The CosmosConflictTests on the other passes locally. |
/check-enforcer override |
Description
This PR fixes the issue when a point-read based
404 / 0
response drops existing point-read based documents from the resultantFeedResponse
instance in spite of the ID of these documents being specified in thereadMany
request. The expected behavior is to ignore non-existent documents but fetch other documents.Testing
Test:
CosmosItemTest#readManyWithMultiplePartitionsAndSome404s
FeedRange
instance for the physical partition. This is done to ensure whenreadMany
is used to query the documents back, it only uses point-reads to do so.readMany
API.readMany
equals (total no. of physical partitions) - nBenchmarking results