Cache bypass in dedicated gateway request options #35865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balalakshmin
requested review from
kushagraThapar,
FabianMeiswinkel,
kirankumarkolli,
xinlian12,
milismsft,
aayush3011,
simorenoh,
jeet1995 and
Pilchie
as code owners
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
sourabh1007
approved these changes
Jul 14, 2023
…to users/balalakshmin/cachebypass
kushagraThapar
requested changes
Aug 9, 2023
...osmos/azure-cosmos/src/main/java/com/azure/cosmos/models/DedicatedGatewayRequestOptions.java
Outdated
Show resolved
Hide resolved
jeet1995
reviewed
Aug 10, 2023
...osmos/azure-cosmos/src/main/java/com/azure/cosmos/models/DedicatedGatewayRequestOptions.java
Outdated
Show resolved
Hide resolved
|
/azp run java - cosmos - tests |
|
Pull request contains merge conflicts. |
…zure/azure-sdk-for-java into users/balalakshmin/cachebypass
…to users/balalakshmin/cachebypass
jeet1995
reviewed
Aug 11, 2023
| requestOptions.setPartitionKey(new PartitionKey(DOCUMENT_ID)); | ||
| ResourceResponse<Document> response = client.readDocument(documentLink, requestOptions).block(); | ||
| if (cacheBypass) { | ||
| String responseHeader = response.getResponseHeaders().get("x-ms-cosmos-cache-bypass"); |
There was a problem hiding this comment.
Synced up offline with @balalakshmin. x-ms-cosmos-cache-bypass response from the service / gateway denotes whether the request hit the cache or not.
jeet1995
approved these changes
Aug 11, 2023
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…to users/balalakshmin/cachebypass
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kushagraThapar
approved these changes
Aug 18, 2023
|
/check-enforcer override |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is to add a new DedicatedGatewayRequestOption "BypassIntegratedCache".
For customers to have more control over integrated cache, we're introducing a new "RequestOption" called "BypassIntegratedCache". This option will allow the customer to decide whether to use integrated cache for each request or not. If this value is set to true, the item/query will be served from backend and won't be cached in Dedicated Gateway.
All SDK Contribution checklist:
Testing Guidelines