Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ThroughputControl]enableThroughputControlOnGateway #36687

Merged
merged 5 commits into from
Sep 13, 2023

Conversation

xinlian12
Copy link
Member

@xinlian12 xinlian12 commented Sep 8, 2023

Enable throughput control on gateway: #34229.

Tests:

val writeCfg = Map(
  "spark.cosmos.accountEndpoint" -> cosmosEndpoint,
  "spark.cosmos.accountKey" -> cosmosMasterKey,
  "spark.cosmos.database" -> "SampleDatabase",
  "spark.cosmos.container" -> "GreenTaxiRecords",
  "spark.cosmos.write.strategy" -> "ItemOverwrite",
  "spark.cosmos.write.bulk.enabled" -> "true",
  "spark.cosmos.throughputControl.enabled" -> "true",
  "spark.cosmos.throughputControl.name" -> "NYCGreenTaxiDataIngestion",
  "spark.cosmos.throughputControl.targetThroughputThreshold" -> "0.85",
  "spark.cosmos.throughputControl.globalControl.database" -> "SampleDatabase",
  "spark.cosmos.throughputControl.globalControl.container" -> "ThroughputControl",
  "spark.cosmos.useGatewayMode" -> "true"
)

image

Notes:
Compared to throughputControl on directMode works on partition level, throughputControl on gateway mode works on container level, so for certain scenarios (like hot partition) it may not work as good as on direct mode.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@xinlian12 xinlian12 changed the title enableThroughputControlOnGateway [ThroughputControl]enableThroughputControlOnGateway Sep 11, 2023
@xinlian12
Copy link
Member Author

/azp run java - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@kushagraThapar kushagraThapar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @xinlian12

@xinlian12
Copy link
Member Author

/azp run java - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xinlian12
Copy link
Member Author

/azp run java - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@xinlian12 xinlian12 force-pushed the enableThroughputControlOnGatewayMode branch from d218fdd to 7c85c51 Compare September 12, 2023 23:13
@xinlian12
Copy link
Member Author

/azp run java - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@xinlian12
Copy link
Member Author

/check-enforcer evaluate

@xinlian12
Copy link
Member Author

/check-enforcer override

@xinlian12
Copy link
Member Author

The Spring Data integration pipeline test failed due to the following reason, not related to the changes in this PR.

Line |
   3 |  . '/mnt/vss/_work/1/s/eng/common/scripts/job-matrix/Create-JobMatrix. …
     |  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | ConfigPath 'sdk/spring/cosmos-integration-matrix.json' does not exist.

@xinlian12 xinlian12 merged commit 9f05b88 into Azure:main Sep 13, 2023
52 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants