alwaysUsePagedFluxMaxItemCount #36847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xinlian12
requested review from
kushagraThapar,
FabianMeiswinkel,
kirankumarkolli,
milismsft,
aayush3011,
simorenoh,
jeet1995 and
Pilchie
as code owners
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
kushagraThapar
approved these changes
Sep 20, 2023
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
xinlian12
force-pushed
the
alwaysUsePageSizeFromPagedFluxIfExists
branch
from
e9023c8
to
45cc67a
Compare
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Failed test: maxValueExceedingDefinedLimitStillWorksWithoutException Tested locally succeeded and the changes in this PR does not touch metrics related logic. |
|
/check-enforcer override |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
PageSizefrombyPageis not always being honoredCosmosQueryRequestOption option = new CosmosQueryRequestOption()
Step 1: query(option).byPage(pageSize)
Step 2: query(option).byPage() -> we are expecting it to use the default pageSize in
CosmosPagedFluxOptions, but for certain scenario, it is reusing the pageSize from step1