Aggressive warm up duration fix and sync client warm up fix #36889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gressiveWarmUpDurationFix # Conflicts: # sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/ProactiveConnectionManagementTest.java # sdk/cosmos/azure-cosmos/CHANGELOG.md
jeet1995
requested review from
kushagraThapar,
FabianMeiswinkel,
kirankumarkolli,
xinlian12,
milismsft,
aayush3011,
simorenoh and
Pilchie
as code owners
|
API change check API changes are not detected in this pull request. |
xinlian12
reviewed
Sep 21, 2023
xinlian12
reviewed
Sep 21, 2023
xinlian12
reviewed
Sep 21, 2023
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosAsyncClient.java
Outdated
Show resolved
Hide resolved
xinlian12
reviewed
Sep 21, 2023
| .withAggressiveWarmupDuration(Duration.ofMinutes(1000)) | ||
| .withIsSystemPropertySetBeforeDirectConnectionConfig(false) | ||
| .withIsSyncClient(false), | ||
| new ProactiveConnectionManagementTestConfig() |
There was a problem hiding this comment.
since we introduced faultInjection on gateway, can we also add test cases where some errors during the warm up stage - for example collection read timed out etc. - can be in a different PR
There was a problem hiding this comment.
Tracking the work item here - #33088
kushagraThapar
approved these changes
Sep 22, 2023
…gressiveWarmUpDurationFix # Conflicts: # sdk/cosmos/azure-cosmos/CHANGELOG.md
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/check-enforcer override |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following bugs:
CosmosClientorCosmosAsyncClientwould block until aggressive warm up duration elapses. This should not be the case when warm up can complete before this duration.CosmosClientopened connections defensively even during the warmup phase. Defensive connection establishment should only happen after the client is built.