Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE issue in MetadataRequestRetryPolicy. #38094

Merged
merged 5 commits into from
Dec 19, 2023

Conversation

jeet1995
Copy link
Member

@jeet1995 jeet1995 commented Dec 18, 2023

MetadataRequestRetryPolicy whose responsibility is to mark a region as unavailable cannot do so when locationEndpointToRoute is null (an example - reading the DatabaseAccount). In such cases, this retry policy should behave as a pass-through.

Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

com.azure:azure-cosmos

@kushagraThapar
Copy link
Member

kushagraThapar commented Dec 18, 2023

API change check

APIView has identified API level changes in this PR and created following API reviews.

com.azure:azure-cosmos

@jeet1995
Copy link
Member Author

/azp run java - cosmos - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jeet1995
Copy link
Member Author

/azp run java - cosmos - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jeet1995 jeet1995 merged commit 1c2f550 into Azure:main Dec 19, 2023
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants