-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NPE issue in MetadataRequestRetryPolicy. #38094
Merged
jeet1995
merged 5 commits into
Azure:main
from
jeet1995:MetadataRequestRetryPolicyNPEFix
Dec 19, 2023
Merged
Fix NPE issue in MetadataRequestRetryPolicy. #38094
jeet1995
merged 5 commits into
Azure:main
from
jeet1995:MetadataRequestRetryPolicyNPEFix
Dec 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeet1995
requested review from
kushagraThapar,
FabianMeiswinkel,
kirankumarkolli,
xinlian12,
milismsft,
aayush3011,
simorenoh and
Pilchie
as code owners
December 18, 2023 15:06
FabianMeiswinkel
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
API change check APIView has identified API level changes in this PR and created following API reviews. |
kushagraThapar
approved these changes
Dec 18, 2023
API change check APIView has identified API level changes in this PR and created following API reviews. |
/azp run java - cosmos - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
…tadataRequestRetryPolicyNPEFix
/azp run java - cosmos - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MetadataRequestRetryPolicy
whose responsibility is to mark a region as unavailable cannot do so whenlocationEndpointToRoute
isnull
(an example - reading theDatabaseAccount
). In such cases, this retry policy should behave as a pass-through.