Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addCustomizedSubstatusCodeForClientGenerated500 #38518

Merged
merged 7 commits into from
Jan 29, 2024

Conversation

xinlian12
Copy link
Member

@xinlian12 xinlian12 commented Jan 26, 2024

Issue:
For certain situations, the request may fail with 500, however the current diagnostics lacking details to identify what could have caused 500

Example Diagnostics:

 "responseStatisticsList": [
                    {
                        "storeResult": {
                            "storePhysicalAddress": "rntbd://membership-prod-prod-cosmos-eastus2.documents.azure.com:36278/apps/7dcbfec6-2f89-4b40-9a14-c692e4b05ed4/services/d46ffeae-93db-45b2-a2ef-765415eea39b/partitions/f7af9b8a-9ce4-4af6-85d3-fb7ab7c28d50/replicas/133112526105274695s/",
                            "lsn": -1,
                            "globalCommittedLsn": -1,
                            "partitionKeyRangeId": null,
                            "isValid": false,
                            "statusCode": 500,
                            "subStatusCode": 0,
                            "isGone": false,
                            "isNotFound": false,
                            "isInvalidPartition": false,
                            "isThroughputControlRequestRateTooLarge": false,
                            "requestCharge": 0.0,
                            "itemLSN": -1,
                            "sessionToken": null,
                            "backendLatencyInMs": null,
                            "retryAfterInMs": null,
                            "exceptionMessage": "Unknown server error occurred when processing this request. If the issue persists, please contact Azure Support: http://aka.ms/azure-support",
                            "exceptionResponseHeaders": "{}",
                            "replicaStatusList": [],
                            "transportRequestTimeline": null,
                            "rntbdRequestLengthInBytes": 0,
                            "rntbdResponseLengthInBytes": 0,
                            "requestPayloadLengthInBytes": 0,
                            "responsePayloadLengthInBytes": 0,
                            "channelStatistics": null,
                            "serviceEndpointStatistics": null
                        },

Changes:

  • Adding customized status code for client generated 500

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - except for making sure to "register" the sub staus codes in msdata and statusCodes.md

Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@xinlian12
Copy link
Member Author

/azp run java - cosmos - spark

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@xinlian12
Copy link
Member Author

/azp run java - cosmos - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@FabianMeiswinkel
Copy link
Member

/azp run java - cosmos - tests

@FabianMeiswinkel
Copy link
Member

/azp run java - cosmos - spark

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@xinlian12 xinlian12 merged commit 36e0d86 into Azure:main Jan 29, 2024
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants