-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add global thread pool concept to azure-core #38860
Merged
alzimmermsft
merged 18 commits into
Azure:main
from
alzimmermsft:AzCore_GlobalThreadPool
May 1, 2024
Merged
Add global thread pool concept to azure-core #38860
alzimmermsft
merged 18 commits into
Azure:main
from
alzimmermsft:AzCore_GlobalThreadPool
May 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdk/core/azure-core/src/main/java/com/azure/core/util/CoreUtils.java
Outdated
Show resolved
Hide resolved
sdk/core/azure-core/src/main/java/com/azure/core/util/CoreUtils.java
Outdated
Show resolved
Hide resolved
API change check APIView has identified API level changes in this PR and created following API reviews. |
srnagar
reviewed
Mar 20, 2024
sdk/core/azure-core/src/main/java/com/azure/core/util/SharedExecutorService.java
Outdated
Show resolved
Hide resolved
sdk/core/azure-core/src/main/java/com/azure/core/util/SharedExecutorService.java
Outdated
Show resolved
Hide resolved
sdk/core/azure-core/src/main/java/com/azure/core/util/SharedExecutorService.java
Show resolved
Hide resolved
sdk/core/azure-core/src/main/java/com/azure/core/util/SharedExecutorService.java
Outdated
Show resolved
Hide resolved
sdk/core/azure-core/src/main/java/com/azure/core/util/SharedExecutorService.java
Outdated
Show resolved
Hide resolved
sdk/core/azure-core/src/main/java/com/azure/core/util/SharedExecutorService.java
Outdated
Show resolved
Hide resolved
sdk/core/azure-core/src/main/java/com/azure/core/util/SharedExecutorService.java
Outdated
Show resolved
Hide resolved
sdk/core/azure-core/src/main/java/com/azure/core/util/SharedExecutorService.java
Outdated
Show resolved
Hide resolved
alzimmermsft
requested review from
anuchandy,
lmolkova,
vcolin7,
mssfang and
billwert
as code owners
April 29, 2024 15:37
lmolkova
reviewed
Apr 29, 2024
sdk/core/azure-core/src/main/java/com/azure/core/util/SharedExecutorService.java
Outdated
Show resolved
Hide resolved
lmolkova
reviewed
Apr 29, 2024
sdk/core/azure-core/src/main/java/com/azure/core/util/SharedExecutorService.java
Outdated
Show resolved
Hide resolved
lmolkova
reviewed
Apr 29, 2024
sdk/core/azure-core/src/main/java/com/azure/core/util/SharedExecutorService.java
Show resolved
Hide resolved
lmolkova
reviewed
Apr 29, 2024
sdk/core/azure-core/src/main/java/com/azure/core/util/SharedExecutorService.java
Outdated
Show resolved
Hide resolved
lmolkova
approved these changes
Apr 30, 2024
sdk/core/azure-core/src/main/java/com/azure/core/util/SharedExecutorService.java
Outdated
Show resolved
Hide resolved
sdk/core/azure-core/src/main/java/com/azure/core/util/SharedExecutorService.java
Outdated
Show resolved
Hide resolved
srnagar
reviewed
Apr 30, 2024
sdk/core/azure-core/src/main/java/com/azure/core/util/CoreUtils.java
Outdated
Show resolved
Hide resolved
sdk/core/azure-core/src/main/java/com/azure/core/util/SharedExecutorService.java
Outdated
Show resolved
Hide resolved
sdk/core/azure-core/src/main/java/com/azure/core/util/SharedExecutorService.java
Outdated
Show resolved
Hide resolved
sdk/core/azure-core/src/main/java/com/azure/core/util/SharedExecutorService.java
Outdated
Show resolved
Hide resolved
sdk/core/azure-core/src/main/java/com/azure/core/util/SharedExecutorService.java
Outdated
Show resolved
Hide resolved
sdk/core/azure-core/src/main/java/com/azure/core/util/SharedExecutorService.java
Show resolved
Hide resolved
sdk/core/azure-core/src/main/java/com/azure/core/util/SharedExecutorService.java
Outdated
Show resolved
Hide resolved
sdk/core/azure-core/src/main/java/com/azure/core/util/SharedExecutorService.java
Show resolved
Hide resolved
srnagar
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lmolkova
reviewed
Apr 30, 2024
sdk/core/azure-core/src/main/java/com/azure/core/util/Configuration.java
Outdated
Show resolved
Hide resolved
lmolkova
reviewed
Apr 30, 2024
sdk/core/azure-core/src/main/java/com/azure/core/util/SharedExecutorService.java
Outdated
Show resolved
Hide resolved
lmolkova
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a global thread pool concept to azure-core so that all SDKs don't need to manage their own thread pools, possibly leading to hundreds or thousands of threads.
This also includes a concept where the global thread pool can be configuration. The reason for this is cases where theCut from PRThread
s created by the pool need specific permissions, such as environments whereSecurityManager
is being used. We can't handle this centrally as we don't know much about the environment using the SDK, and allowing the thread pool to be set would allow for the environment to use an appropriate way to create threads. Where permissions are properly granted, or additional permissions for the Azure SDK created threads aren't needed.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines