Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global thread pool concept to azure-core #38860

Merged
merged 18 commits into from
May 1, 2024

Conversation

alzimmermsft
Copy link
Member

@alzimmermsft alzimmermsft commented Feb 21, 2024

Description

Adds a global thread pool concept to azure-core so that all SDKs don't need to manage their own thread pools, possibly leading to hundreds or thousands of threads.

This also includes a concept where the global thread pool can be configuration. The reason for this is cases where the Threads created by the pool need specific permissions, such as environments where SecurityManager is being used. We can't handle this centrally as we don't know much about the environment using the SDK, and allowing the thread pool to be set would allow for the environment to use an appropriate way to create threads. Where permissions are properly granted, or additional permissions for the Azure SDK created threads aren't needed. Cut from PR

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added the Azure.Core azure-core label Feb 21, 2024
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

com.azure:azure-core

@alzimmermsft alzimmermsft marked this pull request as ready for review April 29, 2024 15:37
Copy link
Member

@srnagar srnagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alzimmermsft alzimmermsft merged commit b36fb68 into Azure:main May 1, 2024
20 checks passed
@alzimmermsft alzimmermsft deleted the AzCore_GlobalThreadPool branch May 1, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Core azure-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants