Generate SDK based on TypeSpec 0.15.6 (with stream-style-serialization=false to some lib) #39287

weidongxu-microsoft · 2024-03-19T01:59:14Z

spec PR Azure/azure-rest-api-specs#28305 -- disabled stream-style-serialization for 6 libs

include migrate to stream-style-serialization for 4 libs:

azure-ai-contentsafety
azure-developer-devcenter
azure-ai-documentintelligence
azure-analytics-purview-datamap

skip openai
skip easm
Will create separate task for them (either update to latest typespec, or try migrate to stream-style-serialization which need a new test recording)

Link #38569

apiview for contentsafety

#39287 (comment)

diff

API added TextBlocklist createOrUpdateTextBlocklist(String name, TextBlocklist options).
It is JSON Merge Patch API that is supported under stream-style-serialization.

@zhaiyutong Please take a review. I may need your help to run the live test (or help me with the env that runs it) and a follow-up release.

apiview for communication-messages

https://apiview.dev/Assemblies/Review/6562e5ee918f497cba32cbf009b4de95/e81ad5b30e934034b274badd1404e691?diffRevisionId=beebd3ccefc94828975b409514c235c6&doc=False&diffOnly=True

This module is not migrated to stream-style-serialization.
These added "Kind" classes corresponds to the discriminator properties.

@arifibrahim4 Please take a review.

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

The pull request does not introduce [breaking changes]
CHANGELOG is updated for new features, bug fixes or other significant changes.
I have read the contribution guidelines.

General Guidelines and Best Practices

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

...entintelligence/src/main/java/com/azure/ai/documentintelligence/models/OperationDetails.java

...s/src/main/java/com/azure/health/insights/radiologyinsights/models/FhirR4DomainResource.java

weidongxu-microsoft · 2024-03-19T02:55:19Z

One major issue is from text-translation
Azure/autorest.java#2629

(if this is the only remaining block, I would change it to stream-style-serialization=false)

alzimmermsft · 2024-03-26T15:25:07Z

...ain/java/com/azure/communication/jobrouter/implementation/models/BestWorkerModeInternal.java

-     * default scoring formula that uses the number of job labels that the worker labels match, as well as the number
-     * of label selectors the worker labels match and/or exceed using a logistic function
-     * (https://en.wikipedia.org/wiki/Logistic_function).
+     * Define a scoring rule to use, when calculating a score to determine the best worker. If not set, will use a default scoring formula that uses the number of job labels that the worker labels match, as well as the number of label selectors the worker labels match and/or exceed using a logistic function (https://en.wikipedia.org/wiki/Logistic_function).


Seems Javadoc formatting broke?

Does checkstyle no longer check char per line on Javadoc/comment?

I thought previously checkstyle would fail if line over 120 (exclude a few exceptions that line break not possible).

It should, but I'll need to check if there is a suppression that is including too much to be skipped.

I think the line wrap on Javadoc comment works on the new release 0.15.6.

Here is just comment, and line wrap not taking effect.

alzimmermsft · 2024-03-26T15:26:51Z

...anslation-text/src/main/java/com/azure/ai/translation/text/TextTranslationClientBuilder.java

+import com.azure.core.credential.KeyCredential;
+import com.azure.core.credential.TokenCredential;
+import java.net.MalformedURLException;
+import java.net.URL;


Hmmm, something seems off with formatting. I'll take a look into why this is happening

Is it the order of the "import"?

I guess part of it is via partial-update, when java-parser merge the imports from existing file and imports from generate file.

The part on formatting seems that it no longer order the imports.

weidongxu-microsoft · 2024-03-27T05:02:48Z

eng/code-quality-reports/src/main/resources/revapi/revapi.json

+        {
+          "ignore": true,
+          "code": "java.annotation.removed",
+          "package": "com.azure.ai.contentsafety.models",
+          "annotationType": "com.fasterxml.jackson.annotation.JsonProperty",
+          "justification": "Migrate to azure-json."
+        },
+        {
+          "ignore": true,
+          "code": "java.annotation.removed",
+          "package": "com.azure.ai.contentsafety.models",
+          "annotationType": "com.fasterxml.jackson.annotation.JsonCreator",
+          "justification": "Migrate to azure-json."
        }


Suppress revapi on removal of Jackson annotations, currently only for contentsafety -- the GA lib.

weidongxu-microsoft and others added 3 commits March 19, 2024 09:29

temporary point commitId to PR head

b80d911

[Automation] Generate SDK based on TypeSpec 0.15.3 (#39286)

30e3d4f

fix module-info

ba9c36e

github-actions bot added DevCenter OpenAI labels Mar 19, 2024

weidongxu-microsoft changed the title ~~temporary point commitId to PR head~~ Generate SDK based on TypeSpec 0.15.3 (with stream-style-serialization=false to some lib) Mar 19, 2024

weidongxu-microsoft commented Mar 19, 2024

View reviewed changes

...entintelligence/src/main/java/com/azure/ai/documentintelligence/models/OperationDetails.java Outdated Show resolved Hide resolved

weidongxu-microsoft commented Mar 19, 2024

View reviewed changes

...s/src/main/java/com/azure/health/insights/radiologyinsights/models/FhirR4DomainResource.java Outdated Show resolved Hide resolved

revert easm

12ffe4f

weidongxu-microsoft mentioned this pull request Mar 19, 2024

Using stream-style-serialization: true for Assistants #38725

Closed

weidongxu-microsoft and others added 5 commits March 21, 2024 16:57

disable stream-style-serialization for azure-ai-translation-text

f1c272a

Merge branch 'main' into dpg_sync-0.15.3

2ac55ab

[Automation] Generate SDK based on TypeSpec 0.15.3

c7b0e32

revert module-info

9e05204

revert easm

3f51f28

weidongxu-microsoft mentioned this pull request Mar 26, 2024

Migrate JSON serialization to azure-json #38569

Open

[Automation] Generate SDK based on TypeSpec 0.15.4

577e6e5

weidongxu-microsoft changed the title ~~Generate SDK based on TypeSpec 0.15.3 (with stream-style-serialization=false to some lib)~~ Generate SDK based on TypeSpec 0.15.4 (with stream-style-serialization=false to some lib) Mar 26, 2024

weidongxu-microsoft added 8 commits March 26, 2024 13:38

remove generated test

95f3623

fix tab in azure-health-insights-radiologyinsights

6b2f58f

stream=false for assistants

fbf157f

regen openai from latest spec

2d666a7

regen

9eb6c29

Merge branch 'main' into dpg_sync-0.15.3

cd58b0a

revert openai

f171cab

update tsp-location

60dd6eb

alzimmermsft reviewed Mar 26, 2024

View reviewed changes

alzimmermsft approved these changes Mar 26, 2024

View reviewed changes

weidongxu-microsoft added 2 commits March 27, 2024 11:58

update tsp-location.yaml targeting commit on main branch

1e07ae1

regen with 0.15.5

10558f8

weidongxu-microsoft changed the title ~~Generate SDK based on TypeSpec 0.15.4 (with stream-style-serialization=false to some lib)~~ Generate SDK based on TypeSpec 0.15.5 (with stream-style-serialization=false to some lib) Mar 27, 2024

weidongxu-microsoft commented Mar 27, 2024

View reviewed changes

azure-sdk and others added 2 commits March 28, 2024 05:49

[Automation] Generate SDK based on TypeSpec 0.15.6

dfc289a

revert openai

871e365

weidongxu-microsoft changed the title ~~Generate SDK based on TypeSpec 0.15.5 (with stream-style-serialization=false to some lib)~~ Generate SDK based on TypeSpec 0.15.6 (with stream-style-serialization=false to some lib) Mar 28, 2024

weidongxu-microsoft marked this pull request as ready for review March 28, 2024 07:01

weidongxu-microsoft requested review from mssfang, JonathanGiles, hallipr, weshaggard, benbp, JimSuplizio, sebrenna, mharlan, joshfree, srnagar, anuchandy, conniey and lmolkova as code owners March 28, 2024 07:01

mssfang mentioned this pull request Mar 29, 2024

[OpenAI] Enable stream-style-serialization Inference #39464

Closed

weidongxu-microsoft requested review from zhaiyutong and arifibrahim4 April 1, 2024 02:55

weidongxu-microsoft self-assigned this Apr 2, 2024

weidongxu-microsoft added the DPG label Apr 2, 2024

haolingdong-msft approved these changes Apr 3, 2024

View reviewed changes

weidongxu-microsoft merged commit f7efe80 into main Apr 3, 2024
141 checks passed

weidongxu-microsoft deleted the dpg_sync-0.15.3 branch April 3, 2024 05:50

weidongxu-microsoft mentioned this pull request Apr 3, 2024

tsp, re-generate openai SDK, targeting latest spec main branch #39520

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Generate SDK based on TypeSpec 0.15.6 (with stream-style-serialization=false to some lib) #39287

Generate SDK based on TypeSpec 0.15.6 (with stream-style-serialization=false to some lib) #39287

weidongxu-microsoft commented Mar 19, 2024 •

edited

Loading

weidongxu-microsoft commented Mar 19, 2024 •

edited

Loading

alzimmermsft Mar 26, 2024

weidongxu-microsoft Mar 27, 2024

alzimmermsft Mar 27, 2024

weidongxu-microsoft Mar 28, 2024

alzimmermsft Mar 26, 2024

weidongxu-microsoft Mar 27, 2024 •

edited

Loading

weidongxu-microsoft Mar 27, 2024 •

edited

Loading

Generate SDK based on TypeSpec 0.15.6 (with stream-style-serialization=false to some lib) #39287

Generate SDK based on TypeSpec 0.15.6 (with stream-style-serialization=false to some lib) #39287

Conversation

weidongxu-microsoft commented Mar 19, 2024 • edited Loading

apiview for contentsafety

apiview for communication-messages

Description

All SDK Contribution checklist:

General Guidelines and Best Practices

Testing Guidelines

weidongxu-microsoft commented Mar 19, 2024 • edited Loading

alzimmermsft Mar 26, 2024

Choose a reason for hiding this comment

weidongxu-microsoft Mar 27, 2024

Choose a reason for hiding this comment

alzimmermsft Mar 27, 2024

Choose a reason for hiding this comment

weidongxu-microsoft Mar 28, 2024

Choose a reason for hiding this comment

alzimmermsft Mar 26, 2024

Choose a reason for hiding this comment

weidongxu-microsoft Mar 27, 2024 • edited Loading

Choose a reason for hiding this comment

weidongxu-microsoft Mar 27, 2024 • edited Loading

Choose a reason for hiding this comment

weidongxu-microsoft commented Mar 19, 2024 •

edited

Loading

weidongxu-microsoft commented Mar 19, 2024 •

edited

Loading

weidongxu-microsoft Mar 27, 2024 •

edited

Loading

weidongxu-microsoft Mar 27, 2024 •

edited

Loading