-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix UserAgent encoding #40293
Merged
FabianMeiswinkel
merged 3 commits into
Azure:main
from
FabianMeiswinkel:usres/fabianm/UserAgentSuffixBugRepro
May 22, 2024
Merged
Fix UserAgent encoding #40293
FabianMeiswinkel
merged 3 commits into
Azure:main
from
FabianMeiswinkel:usres/fabianm/UserAgentSuffixBugRepro
May 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabianMeiswinkel
requested review from
kushagraThapar,
kirankumarkolli,
xinlian12,
milismsft,
aayush3011,
simorenoh,
jeet1995 and
Pilchie
as code owners
May 21, 2024 20:54
Pilchie
reviewed
May 21, 2024
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/UserAgentSuffixTest.java
Show resolved
Hide resolved
API change check API changes are not detected in this pull request. |
kirankumarkolli
approved these changes
May 22, 2024
/azp run java - cosmos - spark |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run java - cosmos - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
Pilchie
approved these changes
May 22, 2024
xinlian12
approved these changes
May 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
Test failures remaining are known flaky tests. |
/check-enforcer override |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When customers use special characters (outside ASCII 0 - 127) in the user agent suffix attempts to connect to the service are blocked when the account is moved to ComputeGateway (it still works when the account is on Routing Gateway). The UserAgent is passed as an http header - and the HTTP spec has in the meantime updated to only allow ASCII characters for http headers (it was initially kept more vague/open - allowing ISO-8859-1) - but then later was narrowed down to ASCII based on the fact that the vast majority of HTTP stacks in the wild only supported ASCII anyway.
This PR masks all non-ASCII characters in UserAgent - by using its matching ASCII character if possible or replacing any remaining non-ASCII character with '_'
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines