Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoiding client-side parsing errors when Gateway returns duplicate unqiueKeyPolicy in IndexPolicy (invalid json) #40306

Conversation

FabianMeiswinkel
Copy link
Member

Description

Defense in depth - since Gateway in two incidents has returned index policy with duplicated uniqueKeyPolicy property we will always allow duplicates for container metadata

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

…policy with duplicated uniqueKeyPolicy property we will always allow duplicates for container metadata
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Copy link
Member

@kushagraThapar kushagraThapar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, is there any way we can add tests for this.

@jeet1995
Copy link
Member

jeet1995 commented May 22, 2024

Can we add a unit test covering the deserialize flow when uniqueKeyPolicy or whatever property for DocumentCollection is repeated > 1 time? Also, the CHANGELOG update.

Copy link
Member

@jeet1995 jeet1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@FabianMeiswinkel FabianMeiswinkel merged commit 1cefaf7 into Azure:main May 22, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants