[Tables] Fix query filter encoding for Date objects #23058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
API change check API changes are not detected in this pull request. |
|
/azp run js - data-tables - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
joheredi
approved these changes
Sep 2, 2022
dgetu
commented
Sep 2, 2022
| @@ -7,7 +7,7 @@ function escapeQuotesIfString(input: unknown, previous: string): string | unknow | |||
| if (typeof input === "string") { | |||
| result = escapeQuotes(input); | |||
| // check if we need to escape this literal | |||
| if (!previous.trim().endsWith("'")) { | |||
| if (previous !== "" && !previous.trim().endsWith("'")) { | |||
There was a problem hiding this comment.
I think we should have more unit tests for odata, as this has the potential to break more things than it fixes.
There was a problem hiding this comment.
Added a test for escaping strings!
|
/azp run js - data-tables - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-js
that referenced
this pull request
Mar 21, 2023
Make failover group status type object to fix resource sync (Azure#23058) * Make status object to fix resource sync * Remove trailing comma * Move changes to 2023-03-15-preview --------- Co-authored-by: Charmaine Chan <chachan@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Querying tables with a filter on a date field was not working. This change fixes that bug.
Fixes #22156