-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Language Text] Prepare for GA #23127
Conversation
API change check APIView has identified API level changes in this PR and created following API reviews. |
@@ -12,9 +12,9 @@ generate-metadata: false | |||
license-header: MICROSOFT_MIT_NO_VERSION | |||
output-folder: ../ | |||
source-code-folder-path: ./src/generated | |||
input-file: https://github.com/Azure/azure-rest-api-specs/blob/cognitiveservices-Language-2022-04-01-preview/specification/cognitiveservices/data-plane/Language/preview/2022-04-01-preview/textanalytics.json | |||
input-file: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/cognitiveservices/data-plane/Language/stable/2022-05-01/analyzetext.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@heaths recommended using this specific commit: https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/textanalytics/azure-ai-textanalytics/swagger/README.md?plain=1#L72
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The generation included in this PR is based off this commit you linked to and I didn't specify it explicitly because I would like to stay up-to-date with my generations.
AnalyzeBatchPoller
has been updated by removingisStarted
,isCanceled
, andisCompleted
. See [core-lro] Deprecate cancelOperation and introduce createPoller #22753 for more details.apiVersion
option in the client class constructor options bag has been renamed toserviceVersion
. A test case has been added.apiVersion
option in the method options bags has been removed because it is difficult to implement at the moment due to limitations in the generated code.