Added support for MicrosoftBotIdentifier #24569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
AikoBB
reviewed
Jan 26, 2023
sdk/communication/communication-common/test/public/identifierModels.spec.ts
Show resolved
Hide resolved
AikoBB
reviewed
Jan 27, 2023
sdk/communication/communication-common/src/identifierModelSerializer.ts
Outdated
Show resolved
Hide resolved
sdk/communication/communication-common/src/identifierModelSerializer.ts
Outdated
Show resolved
Hide resolved
sdk/communication/communication-common/test/public/identifierModels.spec.ts
Show resolved
Hide resolved
Co-authored-by: Dominik <domessin@microsoft.com>
petrsvihlik
approved these changes
Jan 31, 2023
AikoBB
approved these changes
Jan 31, 2023
petrsvihlik
reviewed
Jan 31, 2023
petrsvihlik
reviewed
Jan 31, 2023
petrsvihlik
suggested changes
Jan 31, 2023
ostoliarova-msft
changed the title
petrsvihlik
suggested changes
Feb 2, 2023
Co-authored-by: Petr Švihlík <rocky.intel@gmail.com>
petrsvihlik
approved these changes
Mar 13, 2023
ostoliarova-msft
requested review from
ckairen,
deyaaeldeen,
jeremymeng,
bterlson,
xirzec and
maximrytych-ms
as code owners
AikoBB
approved these changes
Mar 14, 2023
ostoliarova-msft
force-pushed
the
communication/common/teamsbotidentifier
branch
from
8a91ace
to
4300022
Compare
petrsvihlik
approved these changes
Mar 23, 2023
petrsvihlik
approved these changes
Mar 27, 2023
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-js
that referenced
this pull request
Jun 27, 2023
mgmt, managednetworkfabric, update java option (Azure#24569)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
Communication - Common
Issues associated with this PR
User Story 3112539: [SDK][Common][JS] As a developer I can identifer if a user is a Teams User or Bot
Describe the problem that is addressed by this PR
Introducing MicrosoftBotIdentifier, which is a new type of CommunicationIdentifier.
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Added test cases for creating new MicrosoftTeamsBotIdentifier and converting from and to RawId.
Provide a list of related PRs (if any)
#24569
Azure/azure-sdk-for-net#34032
Azure/azure-sdk-for-java#33634
Azure/azure-sdk-for-python#28910
Azure/azure-sdk-for-android#1307
Azure/azure-sdk-for-ios#1468
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists