Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increment client preview versions #4365

Merged
merged 15 commits into from
Jul 22, 2019

Conversation

mikeharder
Copy link
Member

@mikeharder mikeharder commented Jul 19, 2019

@mikeharder mikeharder marked this pull request as ready for review July 19, 2019 22:25
@mikeharder
Copy link
Member Author

/azp run js - eventhubs-client - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@weshaggard
Copy link
Member

For my information is there an npm/rush command/tool you can use to update a version or did you update the version manually in all the projects?

@mikeharder
Copy link
Member Author

For my information is there an npm/rush command/tool you can use to update a version or did you update the version manually in all the projects?

Rush has an experimental command for bumping versions, but I haven't tried it yet and I don't know if our repo is configured correctly for it:

https://rushjs.io/pages/commands/rush_version/

All the updates in this PR were made by hand. Currently the number of packages and dependencies is small enough to make this feasible, but as the repo grows I think we will want a tool to automate this.

@mikeharder
Copy link
Member Author

/azp run js - eventhubs-client - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mikeharder
Copy link
Member Author

/azp run js - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mikeharder mikeharder force-pushed the increment-client-preview-versions branch from 0ba2e14 to e8050f1 Compare July 22, 2019 17:11
Copy link
Member

@bsiegel bsiegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, let’s just make sure to get this step added to our release checklist.

@mikeharder
Copy link
Member Author

Blocked on #4377

@mikeharder mikeharder force-pushed the increment-client-preview-versions branch from 8efbfe8 to faef7be Compare July 22, 2019 22:31
@mikeharder
Copy link
Member Author

/azp run js - eventhubs-client - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mikeharder
Copy link
Member Author

/azp run js - eventhubs-client - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mikeharder mikeharder merged commit 8086331 into Azure:master Jul 22, 2019
@mikeharder mikeharder deleted the increment-client-preview-versions branch July 22, 2019 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increment versions of all shipped preview client libraries
5 participants