-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increment client preview versions #4365
Increment client preview versions #4365
Conversation
/azp run js - eventhubs-client - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
For my information is there an npm/rush command/tool you can use to update a version or did you update the version manually in all the projects? |
Rush has an experimental command for bumping versions, but I haven't tried it yet and I don't know if our repo is configured correctly for it: https://rushjs.io/pages/commands/rush_version/ All the updates in this PR were made by hand. Currently the number of packages and dependencies is small enough to make this feasible, but as the repo grows I think we will want a tool to automate this. |
/azp run js - eventhubs-client - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run js - servicebus - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
0ba2e14
to
e8050f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, let’s just make sure to get this step added to our release checklist.
Blocked on #4377 |
- abort-controller to preview.1 - core-asynciterator-polyfill to preview.1
8efbfe8
to
faef7be
Compare
/azp run js - eventhubs-client - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run js - eventhubs-client - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
A.B.C-preview.1
toA.B.C-preview.2
)^1.0.0-preview.1
to1.0.0-preview.1
) since we allow breaking changes between previews and don't want to roll forward.identity
core-http
core-arm
core-http
. This might be an issue in our packages where we should be using a peer dependency rather than a standard dependency.core-amqp
core-amqp
andevent-hubs
: [core-amqp] Implement exponential retry mechanism #4175service-bus
(depends on [core-amqp] Implement exponential retry mechanism #4175): [core-amqp] Implement exponential retry mechanism #4175