Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[breaking change detector] ignore rule doesn't work when generate changelog #36968

Closed
Tracked by #35515
msyyc opened this issue Aug 21, 2024 · 1 comment · Fixed by #36992
Closed
Tracked by #35515

[breaking change detector] ignore rule doesn't work when generate changelog #36968

msyyc opened this issue Aug 21, 2024 · 1 comment · Fixed by #36992

Comments

@msyyc
Copy link
Member

msyyc commented Aug 21, 2024

I find that ignore rules doesn't work when generate changelog. For example:
when running PS D:\dev\azure-sdk-for-python\sdk\consumption\azure-mgmt-consumption> tox run -c ../../../eng/tox/tox.ini --root . -e breaking, the ignored breakings doesn't appear:

(RemovedOrRenamedEnumValue): The 'BudgetOperatorType' enum had its value 'IN_ENUM' deleted or renamed in the current version
(RemovedOrRenamedInstanceAttribute): The model or publicly exposed class 'CreditSummary' had its instance variable 'e_tag' deleted or renamed in the current version
(RemovedOrRenamedInstanceAttribute): The model or publicly exposed class 'LegacyChargeSummary' had its instance variable 'marketplace_charges' deleted or renamed in the current version

when running PS D:\dev\azure-sdk-for-python\sdk\consumption\azure-mgmt-consumption> tox run -c ../../../eng/tox/tox.ini --root . -e breaking -- --changelog, the ignored breakings about validate still appear:

### Breaking Changes

  - The 'Amount' method 'validate' was deleted or renamed in the current version
  - The 'AmountWithExchangeRate' method 'validate' was deleted or renamed in the current version
  - The 'Balance' method 'validate' was deleted or renamed in the current version
  - The 'BalancePropertiesAdjustmentDetailsItem' method 'validate' was deleted or renamed in the current version
  - The 'BalancePropertiesNewPurchasesDetailsItem' method 'validate' was deleted or renamed in the current version
  - The 'Budget' method 'validate' was deleted or renamed in the current version
  - The 'BudgetComparisonExpression' method 'validate' was deleted or renamed in the current version
  - The 'BudgetFilter' method 'validate' was deleted or renamed in the current version
  - The 'BudgetFilterProperties' method 'validate' was deleted or renamed in the current version
  - The 'BudgetOperatorType' enum had its value 'IN_ENUM' deleted or renamed in the current version
  - The 'BudgetTimePeriod' method 'validate' was deleted or renamed in the current version
  - The 'BudgetsListResult' method 'validate' was deleted or renamed in the current version
  - The 'ChargeSummary' method 'validate' was deleted or renamed in the current version
  - The 'ChargesListResult' method 'validate' was deleted or renamed in the current version
  - The 'CreditBalanceSummary' method 'validate' was deleted or renamed in the current version
  - The model or publicly exposed class 'CreditSummary' had its instance variable 'e_tag' deleted or renamed in the current version
  - The 'CreditSummary' method 'validate' was deleted or renamed in the current version
  - The 'CurrentSpend' method 'validate' was deleted or renamed in the current version
  - The 'DownloadProperties' method 'validate' was deleted or renamed in the current version
  - The 'ErrorDetails' method 'validate' was deleted or renamed in the current version
  - The 'ErrorResponse' method 'validate' was deleted or renamed in the current version
  - The 'EventSummary' method 'validate' was deleted or renamed in the current version
  - The 'Events' method 'validate' was deleted or renamed in the current version
  - The 'ForecastSpend' method 'validate' was deleted or renamed in the current version
  - The 'HighCasedErrorDetails' method 'validate' was deleted or renamed in the current version
  - The 'HighCasedErrorResponse' method 'validate' was deleted or renamed in the current version
  - The model or publicly exposed class 'LegacyChargeSummary' had its instance variable 'marketplace_charges' deleted or renamed in the current version
  - The 'LegacyChargeSummary' method 'validate' was deleted or renamed in the current version
  - The 'LegacyReservationRecommendation' method 'validate' was deleted or renamed in the current version
  - The 'LegacyReservationRecommendationProperties' method 'validate' was deleted or renamed in the current version
  - The 'LegacyReservationTransaction' method 'validate' was deleted or renamed in the current version
  - The 'LegacySharedScopeReservationRecommendationProperties' method 'validate' was deleted or renamed in the current version
  - The 'LegacySingleScopeReservationRecommendationProperties' method 'validate' was deleted or renamed in the current version
  - The 'LegacyUsageDetail' method 'validate' was deleted or renamed in the current version
  - The 'LotSummary' method 'validate' was deleted or renamed in the current version
  - The 'Lots' method 'validate' was deleted or renamed in the current version
  - The 'ManagementGroupAggregatedCostResult' method 'validate' was deleted or renamed in the current version
  - The 'Marketplace' method 'validate' was deleted or renamed in the current version
  - The 'MarketplacesListResult' method 'validate' was deleted or renamed in the current version
  - The 'MeterDetails' method 'validate' was deleted or renamed in the current version
  - The 'MeterDetailsResponse' method 'validate' was deleted or renamed in the current version
  - The 'ModernChargeSummary' method 'validate' was deleted or renamed in the current version
  - The 'ModernReservationRecommendation' method 'validate' was deleted or renamed in the current version
  - The 'ModernReservationTransaction' method 'validate' was deleted or renamed in the current version
  - The 'ModernReservationTransactionsListResult' method 'validate' was deleted or renamed in the current version
  - The 'ModernUsageDetail' method 'validate' was deleted or renamed in the current version
  - The 'Notification' method 'validate' was deleted or renamed in the current version
  - The 'Operation' method 'validate' was deleted or renamed in the current version
  - The 'OperationDisplay' method 'validate' was deleted or renamed in the current version
  - The 'OperationListResult' method 'validate' was deleted or renamed in the current version
  - The 'PriceSheetProperties' method 'validate' was deleted or renamed in the current version
  - The 'PriceSheetResult' method 'validate' was deleted or renamed in the current version
  - The 'ProxyResource' method 'validate' was deleted or renamed in the current version
  - The 'Reseller' method 'validate' was deleted or renamed in the current version
  - The 'ReservationDetail' method 'validate' was deleted or renamed in the current version
  - The 'ReservationDetailsListResult' method 'validate' was deleted or renamed in the current version
  - The 'ReservationRecommendation' method 'validate' was deleted or renamed in the current version
  - The 'ReservationRecommendationDetailsCalculatedSavingsProperties' method 'validate' was deleted or renamed in the current version
  - The 'ReservationRecommendationDetailsModel' method 'validate' was deleted or renamed in the current version
  - The 'ReservationRecommendationDetailsResourceProperties' method 'validate' was deleted or renamed in the current version
  - The 'ReservationRecommendationDetailsSavingsProperties' method 'validate' was deleted or renamed in the current version
  - The 'ReservationDetail' method 'validate' was deleted or renamed in the current version
  - The 'ReservationDetailsListResult' method 'validate' was deleted or renamed in the current version
  - The 'ReservationRecommendation' method 'validate' was deleted or renamed in the current version
  - The 'ReservationRecommendationDetailsCalculatedSavingsProperties' method 'validate' was deleted or renamed in the current version
  - The 'ReservationRecommendationDetailsModel' method 'validate' was deleted or renamed in the current version
  - The 'ReservationRecommendationDetailsResourceProperties' method 'validate' was deleted or renamed in the current version
  - The 'ReservationRecommendationDetailsSavingsProperties' method 'validate' was deleted or renamed in the current version
  - The 'ReservationDetailsListResult' method 'validate' was deleted or renamed in the current version
  - The 'ReservationRecommendation' method 'validate' was deleted or renamed in the current version
  - The 'ReservationRecommendationDetailsCalculatedSavingsProperties' method 'validate' was deleted or renamed in the current version
  - The 'ReservationRecommendationDetailsModel' method 'validate' was deleted or renamed in the current version
  - The 'ReservationRecommendationDetailsResourceProperties' method 'validate' was deleted or renamed in the current version
  - The 'ReservationRecommendationDetailsSavingsProperties' method 'validate' was deleted or renamed in the current version
  - The 'ReservationRecommendation' method 'validate' was deleted or renamed in the current version
  - The 'ReservationRecommendationDetailsCalculatedSavingsProperties' method 'validate' was deleted or renamed in the current version
  - The 'ReservationRecommendationDetailsModel' method 'validate' was deleted or renamed in the current version
  - The 'ReservationRecommendationDetailsResourceProperties' method 'validate' was deleted or renamed in the current version
  - The 'ReservationRecommendationDetailsSavingsProperties' method 'validate' was deleted or renamed in the current version
  - The 'ReservationRecommendationDetailsCalculatedSavingsProperties' method 'validate' was deleted or renamed in the current version
  - The 'ReservationRecommendationDetailsModel' method 'validate' was deleted or renamed in the current version
  - The 'ReservationRecommendationDetailsResourceProperties' method 'validate' was deleted or renamed in the current version
  - The 'ReservationRecommendationDetailsSavingsProperties' method 'validate' was deleted or renamed in the current version
  - The 'ReservationRecommendationDetailsModel' method 'validate' was deleted or renamed in the current version
  - The 'ReservationRecommendationDetailsResourceProperties' method 'validate' was deleted or renamed in the current version
  - The 'ReservationRecommendationDetailsSavingsProperties' method 'validate' was deleted or renamed in the current version
  - The 'ReservationRecommendationDetailsResourceProperties' method 'validate' was deleted or renamed in the current version
  - The 'ReservationRecommendationDetailsSavingsProperties' method 'validate' was deleted or renamed in the current version
  - The 'ReservationRecommendationDetailsUsageProperties' method 'validate' was deleted or renamed in the current version
  - The 'ReservationRecommendationsListResult' method 'validate' was deleted or renamed in the current version
  - The 'ReservationRecommendationDetailsSavingsProperties' method 'validate' was deleted or renamed in the current version
  - The 'ReservationRecommendationDetailsUsageProperties' method 'validate' was deleted or renamed in the current version
  - The 'ReservationRecommendationsListResult' method 'validate' was deleted or renamed in the current version
  - The 'ReservationSummariesListResult' method 'validate' was deleted or renamed in the current version
  - The 'ReservationRecommendationDetailsUsageProperties' method 'validate' was deleted or renamed in the current version
  - The 'ReservationRecommendationsListResult' method 'validate' was deleted or renamed in the current version
  - The 'ReservationSummariesListResult' method 'validate' was deleted or renamed in the current version
  - The 'ReservationRecommendationsListResult' method 'validate' was deleted or renamed in the current version
  - The 'ReservationSummariesListResult' method 'validate' was deleted or renamed in the current version
  - The 'ReservationSummary' method 'validate' was deleted or renamed in the current version
  - The 'ReservationTransaction' method 'validate' was deleted or renamed in the current version
  - The 'ReservationSummariesListResult' method 'validate' was deleted or renamed in the current version
  - The 'ReservationSummary' method 'validate' was deleted or renamed in the current version
  - The 'ReservationTransaction' method 'validate' was deleted or renamed in the current version
  - The 'ReservationSummary' method 'validate' was deleted or renamed in the current version
  - The 'ReservationTransaction' method 'validate' was deleted or renamed in the current version
  - The 'ReservationTransactionResource' method 'validate' was deleted or renamed in the current version
  - The 'ReservationTransactionsListResult' method 'validate' was deleted or renamed in the current version
  - The 'ReservationTransaction' method 'validate' was deleted or renamed in the current version
  - The 'ReservationTransactionResource' method 'validate' was deleted or renamed in the current version
  - The 'ReservationTransactionsListResult' method 'validate' was deleted or renamed in the current version
  - The 'ReservationTransactionResource' method 'validate' was deleted or renamed in the current version
  - The 'ReservationTransactionsListResult' method 'validate' was deleted or renamed in the current version
  - The 'Resource' method 'validate' was deleted or renamed in the current version
  - The 'Resource' method 'validate' was deleted or renamed in the current version
  - The 'ResourceAttributes' method 'validate' was deleted or renamed in the current version
  - The 'SkuProperty' method 'validate' was deleted or renamed in the current version
  - The 'ResourceAttributes' method 'validate' was deleted or renamed in the current version
  - The 'SkuProperty' method 'validate' was deleted or renamed in the current version
  - The 'SkuProperty' method 'validate' was deleted or renamed in the current version
  - The 'Tag' method 'validate' was deleted or renamed in the current version
  - The 'Tag' method 'validate' was deleted or renamed in the current version
  - The 'TagsResult' method 'validate' was deleted or renamed in the current version
  - The 'UsageDetail' method 'validate' was deleted or renamed in the current version
  - The 'UsageDetailsListResult' method 'validate' was deleted or renamed in the current version
  - The 'TagsResult' method 'validate' was deleted or renamed in the current version
  - The 'UsageDetail' method 'validate' was deleted or renamed in the current version
  - The 'UsageDetailsListResult' method 'validate' was deleted or renamed in the current version
  - The 'TagsResult' method 'validate' was deleted or renamed in the current version
  - The 'UsageDetail' method 'validate' was deleted or renamed in the current version
  - The 'TagsResult' method 'validate' was deleted or renamed in the current version
  - The 'TagsResult' method 'validate' was deleted or renamed in the current version
  - The 'UsageDetail' method 'validate' was deleted or renamed in the current version
  - The 'UsageDetailsListResult' method 'validate' was deleted or renamed in the current version
  - The 'TagsResult' method 'validate' was deleted or renamed in the current version
  - The 'UsageDetail' method 'validate' was deleted or renamed in the current version
  - The 'UsageDetailsListResult' method 'validate' was deleted or renamed in the current version
  - The 'TagsResult' method 'validate' was deleted or renamed in the current version
  - The 'UsageDetail' method 'validate' was deleted or renamed in the current version
  - The 'UsageDetailsListResult' method 'validate' was deleted or renamed in the current version
  - The 'TagsResult' method 'validate' was deleted or renamed in the current version
  - The 'UsageDetail' method 'validate' was deleted or renamed in the current version
  - The 'UsageDetailsListResult' method 'validate' was deleted or renamed in the current version
  - The 'TagsResult' method 'validate' was deleted or renamed in the current version
  - The 'TagsResult' method 'validate' was deleted or renamed in the current version
  - The 'UsageDetail' method 'validate' was deleted or renamed in the current version
  - The 'TagsResult' method 'validate' was deleted or renamed in the current version
  - The 'UsageDetail' method 'validate' was deleted or renamed in the current version
  - The 'TagsResult' method 'validate' was deleted or renamed in the current version
  - The 'TagsResult' method 'validate' was deleted or renamed in the current version
  - The 'UsageDetail' method 'validate' was deleted or renamed in the current version
  - The 'UsageDetailsListResult' method 'validate' was deleted or renamed in the current version

Expected:
ignore rules could also work for changelog

@catalinaperalta
Copy link
Member

Thanks for reporting this. I'll pick this up tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants