fix: naive_redirect_server TCP Port should be a u16 #1611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NTmatter
requested review from
heaths,
RickWinter and
JeffreyRichter
as code owners
heaths
approved these changes
Feb 20, 2024
JeffreyRichter
approved these changes
Feb 20, 2024
The Naive Redirect Server function accepts a u32 for what should be a 16-bit unsigned integer. This change changes the function to accept a u16 to avoid out-of-bounds input.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Naive Redirect Server function accepts a u32 for what should be a 16-bit unsigned integer.
This change changes the function to accept a u16 to avoid out-of-bounds input.