Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade controller-runtime, controller-gen, envtest #2217

Merged
merged 2 commits into from
Apr 5, 2022

Conversation

Porges
Copy link
Member

@Porges Porges commented Apr 5, 2022

This seems to pass locally without any other changes.

Changes produced by go get -u sigs.k8s.io/controller-runtime, and manually updating install-dependencies.sh.

kubebuilder no longer installed.

@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2022

Codecov Report

Merging #2217 (a96a76c) into main (d4f5e44) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2217      +/-   ##
==========================================
- Coverage   57.31%   57.30%   -0.01%     
==========================================
  Files         606      606              
  Lines      112653   112653              
==========================================
- Hits        64562    64557       -5     
- Misses      40275    40278       +3     
- Partials     7816     7818       +2     
Impacted Files Coverage Δ
...tools/generator/internal/astmodel/oneof_helpers.go 58.18% <0.00%> (-3.64%) ⬇️
v2/internal/testcommon/kube_client_no_cache.go 65.26% <0.00%> (-3.16%) ⬇️
...e/v1alpha1api20210401/storage_account_types_gen.go 54.88% <0.00%> (-0.10%) ⬇️
...ts/v1alpha1api20180501preview/webtest_types_gen.go 58.37% <0.00%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4f5e44...a96a76c. Read the comment docs.

@Porges Porges changed the title Upgrade controller-runtime Upgrade controller-runtime, controller-gen, envtest Apr 5, 2022
@Porges Porges merged commit 0ec178e into main Apr 5, 2022
@Porges Porges deleted the newer-controller-runtime branch April 5, 2022 05:22
@Porges Porges mentioned this pull request Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants