Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reflection helper SetProperty #3348

Merged
merged 10 commits into from
Oct 3, 2023
Merged

Conversation

theunrepentantgeek
Copy link
Member

What this PR does / why we need it:

As a part of writing an extension for goal-seeking KeyVaults, I need the ability to set a specific property via reflection.
I've pulled this out into a separate helper with thorough testing.

How does this PR make you feel:
gif

If applicable:

  • this PR contains tests

@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2023

Codecov Report

Merging #3348 (d9f8c88) into main (f1a70a4) will decrease coverage by 0.01%.
The diff coverage is 69.04%.

❗ Current head d9f8c88 differs from pull request most recent head a07239f. Consider uploading reports for the commit a07239f to get more accurate results

@@            Coverage Diff             @@
##             main    #3348      +/-   ##
==========================================
- Coverage   54.50%   54.50%   -0.01%     
==========================================
  Files        1511     1511              
  Lines      633427   633469      +42     
==========================================
- Hits       345277   345252      -25     
- Misses     231724   231773      +49     
- Partials    56426    56444      +18     
Files Coverage Δ
v2/internal/reflecthelpers/reflect_helpers.go 71.95% <69.04%> (-0.84%) ⬇️

... and 30 files with indirect coverage changes

@theunrepentantgeek theunrepentantgeek mentioned this pull request Oct 2, 2023
2 tasks
@theunrepentantgeek theunrepentantgeek enabled auto-merge (squash) October 3, 2023 19:06
@theunrepentantgeek
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@theunrepentantgeek theunrepentantgeek merged commit 3e68478 into main Oct 3, 2023
8 checks passed
@theunrepentantgeek theunrepentantgeek deleted the feature/set-by-reflect branch October 3, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

4 participants