-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reflection helper SetProperty #3348
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theunrepentantgeek
requested review from
davefellows,
matthchr,
babbageclunk and
super-harsh
as code owners
September 28, 2023 22:54
Codecov Report
@@ Coverage Diff @@
## main #3348 +/- ##
==========================================
- Coverage 54.50% 54.50% -0.01%
==========================================
Files 1511 1511
Lines 633427 633469 +42
==========================================
- Hits 345277 345252 -25
- Misses 231724 231773 +49
- Partials 56426 56444 +18
|
matthchr
reviewed
Sep 28, 2023
super-harsh
reviewed
Sep 29, 2023
Merged
2 tasks
matthchr
approved these changes
Oct 3, 2023
matthchr
reviewed
Oct 3, 2023
theunrepentantgeek
force-pushed
the
feature/set-by-reflect
branch
from
October 3, 2023 19:06
8516b33
to
d9f8c88
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As a part of writing an extension for goal-seeking KeyVaults, I need the ability to set a specific property via reflection.
I've pulled this out into a separate helper with thorough testing.
How does this PR make you feel:
If applicable: