Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add namespace, label, and annotation support to asoctl #3884

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

matthchr
Copy link
Member

Fixes #3865

If applicable:

  • this PR contains documentation
  • this PR contains tests
  • this PR contains YAML Samples

@matthchr
Copy link
Member Author

/ok-to-test sha=e4192d8

@matthchr matthchr force-pushed the feature/asoctl-namespaces-and-whatnot branch from e4192d8 to ca84263 Compare March 22, 2024 22:12
@matthchr
Copy link
Member Author

/ok-to-test sha=ca84263

@matthchr matthchr force-pushed the feature/asoctl-namespaces-and-whatnot branch from ca84263 to 1da4a91 Compare March 22, 2024 22:57
@matthchr
Copy link
Member Author

/ok-to-test sha=1da4a91

@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 32.46753% with 52 lines in your changes are missing coverage. Please review.

Project coverage is 53.70%. Comparing base (dc6e229) to head (8414dc3).
Report is 4 commits behind head on main.

Files Patch % Lines
...soctl/internal/importing/resource_import_result.go 0.00% 27 Missing ⚠️
v2/internal/annotations/parse.go 50.00% 12 Missing and 5 partials ⚠️
v2/internal/labels/parse.go 50.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3884      +/-   ##
==========================================
+ Coverage   53.53%   53.70%   +0.17%     
==========================================
  Files        1523     1527       +4     
  Lines      550082   552896    +2814     
==========================================
+ Hits       294462   296914    +2452     
- Misses     210086   210426     +340     
- Partials    45534    45556      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthchr matthchr force-pushed the feature/asoctl-namespaces-and-whatnot branch from 1da4a91 to 1e56092 Compare March 24, 2024 00:39
@matthchr
Copy link
Member Author

/ok-to-test sha=1e56092

v2/cmd/asoctl/cmd/import_azure_resource.go Show resolved Hide resolved
v2/cmd/asoctl/cmd/import_azure_resource.go Outdated Show resolved Hide resolved
v2/internal/util/annotations/parse.go Outdated Show resolved Hide resolved
v2/internal/util/annotations/parse.go Outdated Show resolved Hide resolved
v2/internal/util/labels/parse.go Outdated Show resolved Hide resolved
@matthchr matthchr force-pushed the feature/asoctl-namespaces-and-whatnot branch from 1e56092 to a9d8aab Compare March 25, 2024 20:07
@matthchr
Copy link
Member Author

/ok-to-test sha=a9d8aab

@matthchr matthchr force-pushed the feature/asoctl-namespaces-and-whatnot branch from a9d8aab to 8414dc3 Compare March 25, 2024 21:28
@matthchr
Copy link
Member Author

/ok-to-test sha=8414dc3

@matthchr matthchr added this pull request to the merge queue Mar 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 26, 2024
@matthchr matthchr added this pull request to the merge queue Mar 26, 2024
Merged via the queue into Azure:main with commit 6bf4533 Mar 26, 2024
8 checks passed
@matthchr matthchr deleted the feature/asoctl-namespaces-and-whatnot branch March 26, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Support -n namespace specifier for asoctl
3 participants