feat: adds script to setup OIDC issuer #1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1209 +/- ##
=======================================
Coverage 55.49% 55.49%
=======================================
Files 36 36
Lines 2294 2294
=======================================
Hits 1273 1273
Misses 980 980
Partials 41 41 ☔ View full report in Codecov by Sentry. |
aramase
requested changes
Dec 14, 2023
aramase
reviewed
Dec 14, 2023
|
cc @mboersma |
sozercan
reviewed
Dec 14, 2023
mboersma
reviewed
Dec 14, 2023
nilekhc
force-pushed
the
wi-setup
branch
3 times, most recently
from
cb3c07a
to
12bb751
Compare
nilekhc
requested review from
mboersma,
CecileRobertMichon,
aramase and
sozercan
aramase
reviewed
Jan 9, 2024
docs/book/src/installation/self-managed-clusters/oidc-issuer/discovery-document.md
Show resolved
Hide resolved
aramase
requested changes
Jan 30, 2024
docs/book/src/installation/self-managed-clusters/oidc-issuer/discovery-document.md
Outdated
Show resolved
Hide resolved
aramase
requested changes
Jan 30, 2024
aramase
changed the title
|
@mboersma Could you take a look when you get a chance? |
mboersma
reviewed
Jan 30, 2024
|
fyi @jackfrancis |
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
ab63
reviewed
Apr 17, 2024
|
|
||
| LOCATION="${1}" | ||
| RESOURCE_GROUP="${2}" | ||
| AZURE_STORAGE_ACCOUNT="oidcissuer$(openssl rand -hex 4)" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This PR adds script to setup kind cluster for WI. This script does following:
2.a The issuer url can be determined using the storage account and container name.
2.b Let kubeadm generate the signing keys instead of pre-generating and mounting it.
Requirements
Issue Fixed:
Please answer the following questions with yes/no:
Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
Notes for Reviewers: