Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for DNS name before adding to arm template #265

Merged
merged 3 commits into from
May 6, 2020
Merged

Check for DNS name before adding to arm template #265

merged 3 commits into from
May 6, 2020

Conversation

edwardsp
Copy link
Collaborator

@edwardsp edwardsp commented May 5, 2020

This will mean an additional az cli call per public ip

Fix for issue #213

@edwardsp
Check for DNS name before adding to arm template
a52ca73 
This will mean an additional az cli call per public ip
@edwardsp edwardsp requested a review from xpillons May 5, 2020 17:49
xpillons
xpillons approved these changes May 5, 2020
View reviewed changes
Copy link
Collaborator

@xpillons xpillons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, although we need a test case

@edwardsp edwardsp merged commit c4657e8 into master May 6, 2020
@edwardsp edwardsp deleted the bugfix-dnsname-213 branch May 6, 2020 08:18
@xpillons xpillons restored the bugfix-dnsname-213 branch May 6, 2020 08:19
@xpillons xpillons mentioned this pull request May 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xpillons xpillons xpillons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edwardsp @xpillons