Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flags to add ResourceIdentifier #34

Merged
merged 3 commits into from
Oct 19, 2022

Conversation

asilverman
Copy link
Contributor

@asilverman asilverman commented Oct 18, 2022

Identifier is a flag that will be used to mark fields as primary identifiers for an extensibility resource

`ResourceIdentifier` is a flag that will be used to mark fields as primary identifiers for an extensibility resource
@codecov-commenter
Copy link

Codecov Report

Merging #34 (eb2619c) into main (22173f6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #34   +/-   ##
=======================================
  Coverage   94.31%   94.31%           
=======================================
  Files          18       18           
  Lines         299      299           
=======================================
  Hits          282      282           
  Misses         17       17           
Flag Coverage Δ
dotnet 94.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Bicep.Types/Concrete/ObjectType.cs 100.00% <ø> (ø)

@anthony-c-martin
Copy link
Member

Please add a test to

arrayType: { Type: factory.addArrayType(factory.builtInTypes[BuiltInTypeKind.Any]), Flags: ObjectPropertyFlags.None, Description: 'Array of any' },
to verify it can be serialized/deserialized

@anthony-c-martin
Copy link
Member

You'll need to also add this flag


and

Copy link
Member

@anthony-c-martin anthony-c-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants