Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for double-evaluation issue with compile-time imports #13277

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Fix for double-evaluation issue with compile-time imports #13277

merged 2 commits into from
Feb 9, 2024

Conversation

anthony-c-martin
Copy link
Member

@anthony-c-martin anthony-c-martin commented Feb 9, 2024 •
edited by microsoft-github-policy-service bot
Loading

Closes #13250

Microsoft Reviewers: Open in CodeFlow

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 9, 2024 •
edited
Loading

Test this change out locally with the following install scripts (Action run 7848207483)

VSCode
  • Mac/Linux 
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 7848207483
  • Windows 
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 7848207483"
Azure CLI
  • Mac/Linux 
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 7848207483
  • Windows 
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 7848207483"

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 9, 2024 •
edited
Loading

Test Results

    64 files   -     35      64 suites   - 35   25m 31s ⏱️ - 20m 23s
11 015 tests  -     19  11 015 ✅  -     19  0 💤 ±0  0 ❌ ±0 
25 920 runs   - 12 953  25 920 ✅  - 12 953  0 💤 ±0  0 ❌ ±0 

Results for commit 2f28710. ± Comparison against base commit 396ffee.

♻️ This comment has been updated with latest results.

@anthony-c-martin anthony-c-martin merged commit 69631e3 into main Feb 9, 2024
44 checks passed
@anthony-c-martin anthony-c-martin deleted the ant/issue13250 branch February 9, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shenglol shenglol shenglol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import of string variables enclosed in brackets fails with BCP338
2 participants
@anthony-c-martin @shenglol