Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add log analytics storage insights #337

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Add log analytics storage insights #337

merged 1 commit into from
Mar 29, 2022

Conversation

ianlim-cldcvr
Copy link
Contributor

@ianlim-cldcvr ianlim-cldcvr commented Mar 18, 2022 •
edited

Issue-id

PR Checklist

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description

Tried provisioning the resource azurerm_log_analytics_storage_insights but variables were undeclared. Related to aztfmod/terraform-azurerm-caf#1025

Does this introduce a breaking change

  • YES
  • NO

Testing

@ghost
Copy link

ghost commented Mar 18, 2022 •
edited by ghost

CLA assistant check
All CLA requirements met.

arnaudlh
arnaudlh approved these changes Mar 28, 2022
View reviewed changes
Copy link
Member

@arnaudlh arnaudlh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arnaudlh
Copy link
Member

Thanks for your contribution to Cloud Adoption Framework - Terraform - @ianlim-cldcvr!

@arnaudlh arnaudlh merged commit 1e004e4 into Azure:main Mar 29, 2022
@ianlim-cldcvr ianlim-cldcvr deleted the log-analytics-related branch March 29, 2022 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaudlh arnaudlh arnaudlh approved these changes

Assignees

@ianlim-cldcvr ianlim-cldcvr

Labels
5.5.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ianlim-cldcvr @arnaudlh @LaurentLesle