This repository has been archived by the owner on Jul 26, 2024. It is now read-only.
blinQ: Template updates, support for Enterprise Scale module v3.0.0 #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
September 18, 2022 11:08
…storage account and keyvault firewall to Allow all: for some reason bootstrap from Github Codespace don't work with storage account and keyvault firewall rules
…ated rover agent ++
…m-landingzones.git
…ope Standard Time for template/asvm
…ope Standard Time for template/asvm
Added private_endpoints and private_dns to launchpad
…cure_variable_from_command
…r storageaccounts and keyvaults
public_network_access_enabled, subnet_ids +++
Github pipelines and fix minor issues.
keyvaults and storage accounts
and set env.var. for GITHUB org and repo.
normal user and serviceprincipal login
added 22 commits
December 19, 2022 23:05
launchpad.yaml - remove "if rout_table is defined"
azurerm_routes and route_table
missing information about the new route_table_key.
…er to caf_environment for role prefix, should be alz_mg_prefix.
…o level.archtype_resources, should be level.archtype_config according to yaml file.
…refix>-caf-identity, should be <prefix>-identity accourding to the other Azure AD groups.
…ption. Created custom policy set definition and assignment for MDFC config.
…t for MDFC config. Add walkthrough variable for minimalSeverity and update archtype_config_overrides.
|
Changed base to int-5.6.0 branch that we used as a starting point. |
heintonny
commented
Dec 29, 2022
| @@ -16,7 +16,7 @@ | |||
| - name: customer_name | |||
| prompt: Set the short version of your customer name with no spaces | |||
| private: no | |||
| default: contoso | |||
There was a problem hiding this comment.
No point to change the default, let's keep the contoso
| @@ -26,7 +26,7 @@ | |||
| - name: prefix | |||
| prompt: Set the prefix to add to all resource. | |||
| private: no | |||
| default: caf | |||
There was a problem hiding this comment.
No point to change the default, let's keep caf
heintonny
changed the title
|
Will not merge it as 5.6.9 will include it |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue-id
PR Checklist
Description
This pull request might overlap with some of the commits in PR 436. We probably need to discuss this PR in our next meeting.
Main topic for this PR is:
MS might not want to include all these commits based on target architecture decisions, but we belive most of the contribution will benefit the community.
Does this introduce a breaking change
Testing
We have tested the template version locally