Fix #103: Dealing with un-escaped environment variables by using args
#105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiasli
reviewed
Jun 2, 2023
jiasli
reviewed
Jun 2, 2023
jiasli
reviewed
Jun 2, 2023
jiasli
reviewed
Jun 12, 2023
MoChilia
force-pushed
the
master
branch
2 times, most recently
from
49a21af
to
61bb69d
Compare
jiasli
reviewed
Jun 30, 2023
| const AZ_CLI_VERSION_DEFAULT_VALUE = 'agentazcliversion' | ||
|
|
||
| export async function main(){ | ||
| export async function main() { |
There was a problem hiding this comment.
Is there any linter tool for TypeScript? A linter can help us normalize the code style and avoid distracting diffs like this.
Just a reminder. No need to do that right now.
|
Glad to see we are taking security as our top priority and trying our best to avoid possible security risks. Nice work! |
jiasli
approved these changes
Jun 30, 2023
MoChilia
added a commit
to MoChilia/cli
that referenced
this pull request
Aug 9, 2023
MoChilia
added a commit
that referenced
this pull request
Aug 9, 2023
…s` (#105) * escape by args * remove redundant output * fix with comments * update for comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is going to fix #103. We utilize the built-in function in
@actions/exec.execto escape for the incoming arguments.Refer to this instruction, we can implement automatic escape for incoming arguments by using the parameter
argsof function@actions/exec.exec.The reason why only escaping double quotes may not be sufficient was discussed in #104 (comment).
Test workflows
Test Azure CLI for escaping in env