Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing user-defined env variable to be accessible #16

Merged
merged 2 commits into from
Feb 4, 2020

Conversation

jalajmsft
Copy link
Contributor

Addresses issue #13

@jalajmsft jalajmsft requested review from bishal-pdMSFT and biblix and removed request for biblix January 30, 2020 11:27
src/utils.ts Outdated Show resolved Hide resolved
src/main.ts Outdated Show resolved Hide resolved
@jalajmsft jalajmsft merged commit f089509 into master Feb 4, 2020
jalajmsft added a commit that referenced this pull request Feb 4, 2020
* Allowing user-defined env variable to be accessible

* Resolving PR comments
jalajmsft added a commit that referenced this pull request Feb 4, 2020
…uild the code for releases] (#17)

* Allowing user-defined env variable to be accessible (#16)

* Allowing user-defined env variable to be accessible

* Resolving PR comments

* Cherry pick and compile the code
@jalajmsft jalajmsft deleted the users/jaminda/user-defined-env branch February 4, 2020 09:44
kanika1894 added a commit that referenced this pull request Nov 27, 2020
* add lib and node_modules for release branch (#6)

* Users/jaminda/GitHub sha (#9)

* Add GITHUB_SHA environment variable (#8)

* Add GITHUB_SHA environment variable

This PR makes the GITHUB_SHA default environment variable available to use in inlineScript.
This change does not address the issue #7 since it does not pass down all the environment variables (default ones and ones set by the user). This is stopgap solution that should be superseded by a more scalable solution that addresses issue #7 completely.

* separate environment variables parameters

* Adding output files

* GITHUB_* enironement variables are available during script execution (#10) (#12)

* Allowing white-space characters in environment variables (#14) (#15)

* Allow access to user defined variables [Cherry pick from master and build the code for releases] (#17)

* Allowing user-defined env variable to be accessible (#16)

* Allowing user-defined env variable to be accessible

* Resolving PR comments

* Cherry pick and compile the code

* removing node modules

* removing unnecessary files

* updating version

* update gitignore

Co-authored-by: Bishal Prasad <biprasad@microsoft.com>
Co-authored-by: Jalaj Minda <49639049+jalajmsft@users.noreply.github.com>
Co-authored-by: Kanika Pasrija <kanikapasrija@Kanikas-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants