Localization strings for 1.15.0 beta.1 #4332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leah-Xia-Microsoft
requested review from
JamesBurnside,
alkwa-msft,
dmceachernmsft,
carocao-msft,
edwardlee-msft,
PorterNan,
mgamis-msft,
prabhjot-msft,
AmyL219,
jimchou-dev,
vhuseinova-msft,
jpeng-ms,
waynemo,
emlynmac,
JoshuaLai and
palatter
CallWithChat bundle size is not changed.
|
Calling bundle size is not changed.
|
Chat bundle size is not changed.
|
@azure/communication-react jest test coverage for stable.
|
@azure/communication-react jest test coverage for beta.
|
| @@ -315,8 +315,10 @@ | |||
| "startSpotlightCancelButtonLabel": "Отмена", | |||
| "stopSpotlightHeading": "Больше не рекомендовать это видео?", | |||
| "stopSpotlightOnSelfHeading": "Выйти из работы с важным?", | |||
| "stopAllSpotlightHeading": "Отменить все рекомендации видео?", | |||
There was a problem hiding this comment.
It doesn't have the same meaning as in English...
There was a problem hiding this comment.
Created an incident for this
There was a problem hiding this comment.
Created an incident for this
Thanks for checking.
There was a problem hiding this comment.
This should not be a blocker for this beta release since spotlight is not being released yet but thank you for creating an incident @vhuseinova-msft
vhuseinova-msft
approved these changes
Mar 25, 2024
mgamis-msft
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Localization strings for 1.15.0 beta.1
Why
How Tested
Process & policy checklist
Is this a breaking change?