[Storybook v8] Add file for Participant List #4818
Conversation
AmyL219
requested review from
JamesBurnside,
alkwa-msft,
dmceachernmsft,
carocao-msft,
edwardlee-msft,
PorterNan,
mgamis-msft,
prabhjot-msft,
jimchou-dev,
vhuseinova-msft,
Leah-Xia-Microsoft,
jpeng-ms,
waynemo,
emlynmac,
JoshuaLai and
palatter
CallWithChat bundle size is increased❗.
|
Calling bundle size is increased❗.
|
Chat bundle size is increased❗.
|
@azure/communication-react jest test coverage for stable.
|
@azure/communication-react jest test coverage for beta.
|
| @@ -0,0 +1,46 @@ | |||
| import { ParticipantList } from '@azure/communication-react'; | |||
| import { Title, Heading, Description, Canvas, Props, Meta } from '@storybook/addon-docs'; | |||
There was a problem hiding this comment.
There are a couple imports here that aren't used: Title, Heading, Description, Props
There was a problem hiding this comment.
aren't we using @storybook/blocks for these imports and not @storybook/addon-docs
There was a problem hiding this comment.
Both blocks and addon-docs work
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | ||
| const onParticipantRemove = (_userId: string): void => { | ||
| // Do something when remove a participant from list |
There was a problem hiding this comment.
Suggestion: In the image overlay we display an alert pop up, maybe we can do something like that so no need to force the eslint disable
| @@ -0,0 +1,46 @@ | |||
| import { ParticipantList } from '@azure/communication-react'; | |||
| import { Title, Heading, Description, Canvas, Props, Meta } from '@storybook/addon-docs'; | |||
There was a problem hiding this comment.
aren't we using @storybook/blocks for these imports and not @storybook/addon-docs
There was a problem hiding this comment.
storyshots are deprecated, we should be removing this file
Pull Request is not mergeable
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
What
Why
How Tested
Process & policy checklist
Is this a breaking change?