Send client warning when signing is disabled #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpuguy83
force-pushed
the
warning
branch
3 times, most recently
from
a7e9dcb
to
64451ca
Compare
cpuguy83
commented
Jul 12, 2024
| @@ -261,13 +304,14 @@ func (b *BuildxEnv) RunTest(ctx context.Context, t *testing.T, f TestFunc) { | |||
| f(ctx, gwc) | |||
| return gwclient.NewResult(), nil | |||
| }, ch) | |||
| if err != nil { | |||
| t.Fatal(err) | |||
There was a problem hiding this comment.
This fatal call here could sometimes make the test runner yell because a buildkit status message could hit the test log after the fatal is called.
Hence why I moved the <-done after.
cpuguy83
force-pushed
the
warning
branch
2 times, most recently
from
eb7caa3
to
3ffd398
Compare
DannyBrito
reviewed
Jul 15, 2024
DannyBrito
reviewed
Jul 15, 2024
DannyBrito
reviewed
Jul 15, 2024
cpuguy83
force-pushed
the
warning
branch
2 times, most recently
from
1f0e5bb
to
45d8523
Compare
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When signing is explicitly disabled this surfaces a warning message on the client.
Example: