Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing nit comments from previous DW mutation support prs. #2043

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

rohkhann
Copy link
Contributor

Why make this change?

Fixing nit comments from earlier pr: #1978

What is this change?

There were some nit comments to fix while adding implementation for mutation support for DW.

How was this tested?

Existing tests should cover as this pr only handles nit fixes.

@rohkhann
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Contributor

@Aniruddh25 Aniruddh25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for following up and ensuring all the comments are resolved even after merging the PR!

Copy link
Contributor

@seantleonard seantleonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the follow up!

@Aniruddh25
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@rohkhann rohkhann merged commit 81e42c9 into main Feb 16, 2024
14 checks passed
@rohkhann rohkhann deleted the rohkhann/FixingDWMutationComments branch February 16, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants