Eborders/templatevars #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidgamero
reviewed
Aug 3, 2022
davidgamero
reviewed
Aug 3, 2022
davidgamero
reviewed
Aug 3, 2022
davidgamero
reviewed
Aug 4, 2022
davidgamero
reviewed
Aug 4, 2022
There was a problem hiding this comment.
populating integration_config.json with the values we want to test will fix "null" string issue
maybe adding a comment to the generated yamls in /test/integration saying they are "generated by /test/gen_integration.sh" to avoid manual intervention like i did oops
davidgamero
reviewed
Aug 4, 2022
erinborders
commented
Aug 4, 2022
davidgamero
reviewed
Aug 4, 2022
davidgamero
reviewed
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding VERSION variables to the builder dockerfiles so users have more control over the images they're creating, as well as adding default values for those variables.
Also removing VERSION from deploy vars in the gen_integration file for helm, kustomize, and manifests since VERSION is not referenced in deployment, only in the dockerfiles.